Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix types in createAnimatedComponent #5135

Merged
merged 5 commits into from
Oct 6, 2023
Merged

Fix types in createAnimatedComponent #5135

merged 5 commits into from
Oct 6, 2023

Conversation

Latropos
Copy link
Contributor

@Latropos Latropos commented Sep 25, 2023 •
edited
Loading

Summary

I've been recently refactoring createAnimatedComponent, but I've forgot to update types.

  • Replace any with unknown
  • Type viewConfig as ViewConfig
  • Add 'use strict'

Test plan

@Latropos Latropos requested a review from tjzel September 25, 2023 12:53
@Latropos Latropos marked this pull request as ready for review September 25, 2023 12:54
tjzel
tjzel requested changes Sep 25, 2023
View reviewed changes
src/createAnimatedComponent/InlinePropManager.ts Outdated Show resolved Hide resolved
src/createAnimatedComponent/InlinePropManager.ts Outdated Show resolved Hide resolved
@Latropos Latropos requested a review from tjzel September 26, 2023 08:36
@Latropos Latropos marked this pull request as draft September 27, 2023 08:10
@Latropos Latropos marked this pull request as ready for review October 3, 2023 06:22
@Latropos Latropos requested a review from tjzel October 3, 2023 06:22
@Latropos Latropos added this pull request to the merge queue Oct 6, 2023
Merged via the queue into main with commit 68b2234 Oct 6, 2023
7 checks passed
@Latropos Latropos deleted the acynk/fix-animated-component-types branch October 6, 2023 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tjzel tjzel tjzel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Latropos @tjzel