Fix "valueUnpacker is not a worklet" error when Reanimated Babel plugin is missing
#5256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomekzaw
changed the title
threads.ts to valueUnpacker.tsvalueUnpacker is not a worklet" error when Reanimated Babel plugin is missing
piaskowyk
reviewed
Oct 17, 2023
tjzel
requested changes
Oct 18, 2023
tjzel
approved these changes
Oct 19, 2023
tomekzaw
commented
Oct 21, 2023
piaskowyk
approved these changes
Oct 24, 2023
bartlomiejbloniarz
pushed a commit
that referenced
this pull request
Oct 27, 2023
…ugin is missing (#5256) <!-- Thanks for submitting a pull request! We appreciate you spending the time to work on these changes. Please follow the template so that the reviewers can easily understand what the code changes affect. --> ## Summary This PR fixes a regression in troubleshooting when user forgot to setup Reanimated Babel plugin. Currently, a generic error is shown, instead of a developer-friendly user message with a link to the docs. Closes #5209. | Before | After | |:-:|:-:| | <img width="507" alt="Zrzut ekranu 2023-10-17 o 18 20 45" src="https://github.com/software-mansion/react-native-reanimated/assets/20516055/635685a0-91ab-435e-bd56-a3f59460ecb4"> | <img width="507" alt="Zrzut ekranu 2023-10-17 o 18 25 23" src="https://github.com/software-mansion/react-native-reanimated/assets/20516055/23a2cc6d-595c-419d-914e-3637382a4b5f"> | ## Test plan <!-- Provide a minimal but complete code snippet that can be used to test out this change along with instructions how to run it and a description of the expected behavior. -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a regression in troubleshooting when user forgot to setup Reanimated Babel plugin. Currently, a generic error is shown, instead of a developer-friendly user message with a link to the docs.
Closes #5209.
Test plan