[web][fix] Add setValue to InternalAnimatedValue #532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
EvanBacon
commented
Jan 1, 2020
EvanBacon
commented
- fix How to run examples in Web? #481
- throw errors for better debugging when types are passed incorrectly
- fix software-mansion#481 - add errors for better hints when types are passed incorrectly
osdnk
approved these changes
Jan 2, 2020
jakub-gonet
approved these changes
Jan 2, 2020
| @@ -18,11 +18,17 @@ export class AnimatedParam extends AnimatedNode { | |||
| } | |||
|
|
|||
| setValue(value) { | |||
| if (!this.argsStack.length) throw new Error(`param: setValue(${value}) failed because argsStack is empty`); | |||
There was a problem hiding this comment.
Small nitpick, IMO this.argsStack.length === 0 would be better here
| __onEvaluate() { | ||
| if (!this.argsStack.length) throw new Error(`param: __onEvaluate() failed because argsStack is empty`); |
|
ya web support is still very unstable but at least the problems can be addressed now. |
This was referenced Feb 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.