Fix incomplete UI runtime initialization #5505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry for bothering, but is there any chance this will be released soon? |
|
@Nodonisko I'm afraid we don't have enough capacity to publish a stable release this week but we hope to merge this PR this week and it will be available in |
|
Thanks, nightly is fine :) |
tjzel
approved these changes
Dec 21, 2023
|
Hello guys, how to install 3.7.0-nightly via npm? |
|
|
|
Hi @tomekzaw, any plan to release it on stable ? |
|
@huextrat We don't have exact plans when to release 3.7.0 but maybe in 1-2 weeks? |
RikSchefferAmsterdam
pushed a commit
to Amsterdam/amsterdam-app-frontend
that referenced
this pull request
Feb 12, 2024
Voor issue: #104540 ...willen we de fix doorvoeren voor: software-mansion/react-native-reanimated#5505 (ook software-mansion/react-native-reanimated#5421) ...en die is opgelost in: https://github.com/software-mansion/react-native-reanimated/releases/tag/3.7.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #5421, fixes #5331.
This PR removes
installValueUnpackermethod which was called on the JS thread during the creation ofNativeReanimatedModulebut operated directly on the UI runtime. Because of this, UI runtime was already used from JS thread so any use from the UI runtime (e.g. Reanimated event handlers) would cause a crash due to a failed check inReanimatedReentrancyCheck::before. Note that the check also occurred in release mode due to improperly setNDEBUGflag.Test plan