Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SET] Tab Navigator support #5793

Merged
merged 76 commits into from
Jun 25, 2024
Merged

[SET] Tab Navigator support #5793

merged 76 commits into from
Jun 25, 2024

Conversation

piaskowyk
Copy link
Member

@piaskowyk piaskowyk commented Mar 15, 2024

Summary

This PR adds support for shared element transition after navigation tab changed.

Screen.Recording.2024-06-04.at.17.16.01.mov

Test plan

Run TabNavigatorExample form Example app.

@piaskowyk piaskowyk requested review from tjzel and tomekzaw June 4, 2024 15:18
@piaskowyk piaskowyk marked this pull request as ready for review June 4, 2024 15:18
Common/cpp/LayoutAnimations/LayoutAnimationsManager.cpp Outdated Show resolved Hide resolved
Common/cpp/LayoutAnimations/LayoutAnimationsManager.cpp Outdated Show resolved Hide resolved
android/src/main/cpp/LayoutAnimations.cpp Outdated Show resolved Hide resolved
android/src/main/cpp/LayoutAnimations.cpp Outdated Show resolved Hide resolved
android/src/main/cpp/LayoutAnimations.cpp Outdated Show resolved Hide resolved
apple/LayoutReanimation/REAScreensHelper.h Outdated Show resolved Hide resolved
@piaskowyk piaskowyk requested a review from tomekzaw June 11, 2024 08:56
@piaskowyk piaskowyk requested a review from tjzel June 14, 2024 07:54
Copy link
Member

@tomekzaw tomekzaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's just make sure that getSharedGroupBlock is properly mocked on iOS.

@piaskowyk piaskowyk enabled auto-merge June 25, 2024 12:54
@piaskowyk piaskowyk added this pull request to the merge queue Jun 25, 2024
Merged via the queue into main with commit 4f1e289 Jun 25, 2024
15 checks passed
@piaskowyk piaskowyk deleted the @piaskowyk/SET-everywhere branch June 25, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants