-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix documentation details #5922
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…M/react-native-reanimated into @xnameTM/convert-ts-to-js
## Summary This pr adds TypeScript templates of code in the Reanimated Docs. ## How is it work? I rewrote the `.jsx` exercises to `.tsx` and I added tsx to jsx code compilation in the InteractiveExample component. ## How to test this feature? Command to change current working dictionary: > cd docs Command to download libraries: > yarn install Command to preview the project: > yarn start # Screenshots ![Zrzut ekranu 2024-04-8 o 11 33 57](https://github.com/software-mansion/react-native-reanimated/assets/80314375/219ad5ed-681a-43a7-b962-e9fff0a739a5) ![Zrzut ekranu 2024-04-8 o 11 34 26](https://github.com/software-mansion/react-native-reanimated/assets/80314375/69e59174-0273-4c6f-a356-4c231180884b) ![Zrzut ekranu 2024-04-8 o 11 34 46](https://github.com/software-mansion/react-native-reanimated/assets/80314375/acc3a65a-50d6-453f-8a10-b808d173bffa)
piaskowyk
reviewed
Apr 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
## Summary This PR includes a playground to withDecay subpage. ## Preview withDecay Playground <img width="994" alt="Zrzut ekranu 2024-04-26 o 12 23 33" src="https://github.com/software-mansion/react-native-reanimated/assets/80314375/cd1c69a2-4309-48ae-a0f3-8319a1cae87a"> ## Test plan Command to change current working dictionary: > cd docs Command to download libraries: > yarn Command to preview feature: > yarn start
## Summary This PR includes a playground to withRepeat subpage. ## Preview withRepeat Playground <img width="1024" alt="Zrzut ekranu 2024-04-19 o 14 38 33" src="https://github.com/software-mansion/react-native-reanimated/assets/80314375/cbdcf6c6-8d34-4fe3-a4aa-9e5a196b9273"> ## Test plan Command to change current working dictionary: > cd docs Command to download libraries: > yarn Command to preview feature: > yarn start
patrycjakalinska
approved these changes
May 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
patrycjakalinska
changed the title
Fix for documentation details
Fix documentation details
May 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR includes changes such as fixing
thumbs
in playgrounds, fixinginteractive
Reanimated
text on mobile devices, and addedresponsiveness
to examples and playgrounds.How to test this feature?
Command to change current working dictionary:
Command to download libraries:
Command to preview changes: