-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix getRelativeCoords
computing
#5926
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Runtime tests coming soon ™️ |
Latropos
reviewed
Apr 25, 2024
app/src/examples/RuntimeTests/tests/getRelativeCoords/relativeCoords.test.tsx
Outdated
Show resolved
Hide resolved
Latropos
reviewed
Apr 25, 2024
app/src/examples/RuntimeTests/tests/getRelativeCoords/relativeCoords.test.tsx
Outdated
Show resolved
Hide resolved
Latropos
approved these changes
Apr 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work, I've left some type suggestions!
app/src/examples/RuntimeTests/tests/getRelativeCoords/relativeCoords.test.tsx
Outdated
Show resolved
Hide resolved
app/src/examples/RuntimeTests/tests/getRelativeCoords/relativeCoords.test.tsx
Outdated
Show resolved
Hide resolved
app/src/examples/RuntimeTests/tests/getRelativeCoords/relativeCoords.test.tsx
Outdated
Show resolved
Hide resolved
app/src/examples/RuntimeTests/tests/getRelativeCoords/relativeCoords.test.tsx
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Inspired by #5810, seems like
getRelativeCoords
wrongly computes relative cords. For some reason, an absolute point was being compared to relative cords of given component (x
andy
frommeasure
instead ofpageX
andpageY
).Test plan
You can run the following code (start a pan gesture from the pink square and the coords are computed at the point of gesture end relatively to the purple square - see console logs):
Code