Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some typos #5930

Merged
merged 3 commits into from
Apr 23, 2024
Merged

Fix some typos #5930

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
199886c
Fix typos
m-bert Apr 23, 2024
1fad6a1
Add another correct words
m-bert Apr 23, 2024
c50f591
Add snapshotting to words
m-bert Apr 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions cspell.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,11 @@
"workletizes",
"workletized",
"barfoo",
"devs"
],
"ignorePaths": [
"node_modules",
"docs/src/components/Testimonials"
"devs",
"lightspeed",
"easings",
"snapshotting"
],
"ignorePaths": ["node_modules", "docs/src/components/Testimonials"],
"useGitignore": true
}

2 changes: 1 addition & 1 deletion src/reanimated2/layoutReanimation/web/animationsManager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ function checkUndefinedAnimationFail(
}

console.warn(
"[Reanimated] Couldn't load entering/exiting animation. Current version supports only predefined animations with modifiers: duration, delay, easing, randomizeDelay, wtihCallback, reducedMotion."
"[Reanimated] Couldn't load entering/exiting animation. Current version supports only predefined animations with modifiers: duration, delay, easing, randomizeDelay, withCallback, reducedMotion."
);

return true;
Expand Down
2 changes: 1 addition & 1 deletion src/reanimated2/layoutReanimation/web/componentUtils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,7 +276,7 @@ export function handleExitingAnimation(

const scrollOffsets = getElementScrollValue(element);

// Scroll does not trigger snapshoting, therefore if we start exiting animation after
// Scroll does not trigger snapshotting, therefore if we start exiting animation after
// scrolling through parent component, dummy will end up in wrong place. In order to fix that
// we keep last known scroll position in snapshot and then adjust dummy position based on
// last known scroll offset and current scroll offset
Expand Down
4 changes: 2 additions & 2 deletions src/reanimated2/layoutReanimation/web/createAnimation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ import { FadingTransition } from './transition/Fading.web';
import { insertWebAnimation } from './domUtils';

// Translate values are passed as numbers. However, if `translate` property receives number, it will not automatically
// convert it to `px`. Therefore if we want to keep exisitng transform we have to add 'px' suffix to each of translate values
// convert it to `px`. Therefore if we want to keep existing transform we have to add 'px' suffix to each of translate values
// that are present inside transform.
function addPxToTranslate(
existingTransform: NonNullable<TransformsStyle['transform']>
Expand Down Expand Up @@ -43,7 +43,7 @@ function addPxToTranslate(
return newTransform;
}

// In order to keep exisitng transform throughout animation, we have to add it to each of keyframe step.
// In order to keep existing transform throughout animation, we have to add it to each of keyframe step.
function addExistingTransform(
newAnimationData: AnimationData,
newTransform: ReanimatedWebTransformProperties[]
Expand Down
Loading