-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Monorepo [3/?] - redo WebExample #6008
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 27, 2024
Merged
…sky-and-precommit
…po-make-reanimated-a-workspace
…l/monorepo-webexample
Base automatically changed from
@tjzel/monorepo-make-reanimated-a-workspace
to
@tjzel/monorepo
June 5, 2024 13:36
…code and paper example (#5999) This pull request is a part of the effort of migrating to monorepo structure: - #5992 - #5993 - #5998 This particular pull request moves `app` directory to a package called `reanimated-app` and `Example` directory to `reanimated-paper-example` package. It also makes use of hoisted `node_modules` for those two packages and `react-native-reanimated`. Run `reanimated-paper-example` on both iOS and Android to see that it works.
tjzel
added a commit
that referenced
this pull request
Jun 5, 2024
## About This pull request is a part of the effort of migrating to monorepo structure: - #5992 - #5993 - #5999 - #6008 ## Summary This particular pull requests all our configuration files (ESLint, Prettier, Typescript) to the root directory and extend them in the packages. It also moves `eslint-plugin-reanimated` to a separate package. ## Test plan 🚀
tjzel
added a commit
that referenced
this pull request
Jun 5, 2024
## About This pull request is a part of the effort of migrating to monorepo structure: - #5992 - #5993 - #5999 - #6008 - #6020 ## Summary This particular pull request takes `FabricExample` out of `react-native-reanimated` workspace and turns it into a separate package. ## Test plan New FabricExample app should compile and work as expected.
tjzel
added a commit
that referenced
this pull request
Jun 5, 2024
## About This pull request is a part of the effort of migrating to monorepo structure: - #5992 - #5993 - #5999 - #6008 - #6020 - #6023 ## Summary This particular pull request takes `NextExample` out of `react-native-reanimated` workspace and turns it into a separate package. ## Test plan New NextExample app should compile and work as expected.
tjzel
added a commit
that referenced
this pull request
Jun 5, 2024
## About This pull request is a part of the effort of migrating to monorepo structure: - #5992 - #5993 - #5999 - #6008 - #6020 - #6023 ## Summary This particular pull request takes `MacOSExample` out of `react-native-reanimated` workspace and turns it into a separate package. ## Test plan New MacOSExample app should compile and work as expected. --------- Co-authored-by: Krzysztof Piaskowy <krzysztof.piaskowy@swmansion.com>
tjzel
added a commit
that referenced
this pull request
Jun 5, 2024
## About This pull request is a part of the effort of migrating to monorepo structure: - #5992 - #5993 - #5999 - #6008 - #6020 - #6023 - #6029 ## Summary This particular pull request takes our docs out of `react-native-reanimated` workspace and turns it into a separate package. However, due to some issues that seem to stem from Docusaurus and Yarn versions, it doesn't work as a workspace. For now we will use it just like we did before, with its own `yarn.lock` etc. until we are able to fix that. ## Test plan Docs should compile and work as expected. --------- Co-authored-by: Krzysztof Piaskowy <krzysztof.piaskowy@swmansion.com>
tjzel
added a commit
that referenced
this pull request
Jun 5, 2024
## About This pull request is a part of the effort of migrating to monorepo structure: - #5992 - #5993 - #5999 - #6008 - #6020 - #6023 - #6029 - #6051 ## Summary This particular pull request takes `TVOSExample` out of `react-native-reanimated` workspace and turns it into a separate package. ## Test plan TVOSExample should compile and work as expected. --------- Co-authored-by: Krzysztof Piaskowy <krzysztof.piaskowy@swmansion.com>
tjzel
added a commit
that referenced
this pull request
Jun 5, 2024
## About This pull request is a part of the effort of migrating to monorepo structure: - #5992 - #5993 - #5998 - #5999 - #6008 - #6020 - #6023 - #6029 - #6051 - #6053 ## Summary This particular pull request takes removes `reanimated2` directory from `src`. ## Test plan Example apps should work as expected. --------- Co-authored-by: Krzysztof Piaskowy <krzysztof.piaskowy@swmansion.com> Co-authored-by: Michał Bert <michal.bert@swmansion.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About
This pull request is a part of the effort of migrating to monorepo structure:
Summary
This particular pull request setups our Web Example. I had serious issues with re-configuring the previous one to work in monorepo and I decided to build this one from scratch.
Test plan
New Web Example should work just like the old one.