Fix slow animation mode on Android #6014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@piaskowyk I believe PR title is confusing, I read it like "improve the performance of -normal- animations" 😅 |
|
Hey, this PR is about our feature that slow down all animation for debugging purposes 😅 Screen.Recording.2024-05-14.at.15.01.44.mp4 |
piaskowyk
changed the title
bartlomiejbloniarz
approved these changes
Jun 11, 2024
...ges/react-native-reanimated/android/src/main/java/com/swmansion/reanimated/NodesManager.java
Outdated
Show resolved
Hide resolved
tjzel
approved these changes
Jun 12, 2024
...ges/react-native-reanimated/android/src/main/java/com/swmansion/reanimated/NodesManager.java
Show resolved
Hide resolved
...ges/react-native-reanimated/android/src/main/java/com/swmansion/reanimated/NodesManager.java
Outdated
Show resolved
Hide resolved
...ges/react-native-reanimated/android/src/main/java/com/swmansion/reanimated/NodesManager.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the issue of slow animations on Android. We utilize two different sources of timestamps on Android, so we need to slow down both of them instead of just one to fix the problem. Previously, almost all animations were canceled immediately after starting because the current frame timestamp was 10 times higher than the slowed-down start timestamp.
Screen.Recording.2024-05-14.at.14.30.22.mov
Screen.Recording.2024-05-14.at.14.15.50.mov