Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updates to reanimated mock #605

Merged
merged 2 commits into from
Feb 24, 2020
Merged

Conversation

adkenyon
Copy link
Contributor

@adkenyon adkenyon commented Feb 12, 2020

I ran into a number of issues using react-native-reanimated/mock while migrating from react native Animated Api. These changes seem to fix everything for me.

  • Missing Transitioning and Transition components
  • Missing createTransitioningComponent higher order function
  • AnimatedValue has no interpolate function (backwards compatibility issue)
  • Created a mock for the color AnimatedNode
  • react-native-reanimated/mock exports Animated as the default export when it needs to be both export as default and have it's child properties as named exports.

@kmagiera
Copy link
Member

Looks good, mind checking why CI is failing on this one?

@adkenyon
Copy link
Contributor Author

@kmagiera it looks to be an xcode issue. Unrelated to this PR.

** BUILD FAILED **


The following build commands failed:

CompileC /Users/travis/build/software-mansion/react-native-reanimated/Example/ios/build/Build/Intermediates.noindex/Pods.build/Debug-iphonesimulator/React-RCTLinking.build/Objects-normal/x86_64/RCTLinkingManager.o /Users/travis/build/software-mansion/react-native-reanimated/Example/node_modules/react-native/Libraries/LinkingIOS/RCTLinkingManager.m normal x86_64 objective-c com.apple.compilers.llvm.clang.1_0.compiler

(1 failure)

The command "xcodebuild -workspace ./ios/ReanimatedExample.xcworkspace -scheme ReanimatedExample -configuration Debug -sdk iphonesimulator -derivedDataPath ./ios/build -UseModernBuildSystem=NO" exited with 65.

@kmagiera
Copy link
Member

Thanks to @jakub-gonet the CI should be good now. Mind updating your PR to check if it is passing?

@adkenyon
Copy link
Contributor Author

@kmagiera It looks to be working now

@kmagiera
Copy link
Member

Thanks 🙌

@kmagiera kmagiera merged commit 79f3187 into software-mansion:master Feb 24, 2020
@adkenyon adkenyon deleted the update-mocks branch February 24, 2020 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants