Add safer refresh on InteractiveExample #6057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kacperkapusciak
approved these changes
May 28, 2024
patrycjakalinska
deleted the
@patrycjakalinska/refresh-on-interactive-example
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before when page was loading, there was a chance that
widthvalue wouldn't be passed to component inInteractiveComponent- in other words thewidthwill be passed to component before it had become something other thannull, and there won't be a rerender after width gets a number value. After this change, withuseEffecthook, we monitor if width has changed and if so, we trigger a rerender that guarantees our component will always get correct width.