Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add contributing docs page #6061

Merged
merged 32 commits into from
Jun 17, 2024

Conversation

maciekstosio
Copy link
Contributor

@maciekstosio maciekstosio commented May 29, 2024

Contributing guide page in docs describing how to start contributing to Reanimated library.

@kacperkapusciak kacperkapusciak changed the title [WIP] Add contributing docs page Add contributing docs page Jun 13, 2024
@kacperkapusciak kacperkapusciak marked this pull request as ready for review June 13, 2024 07:55
@kacperkapusciak kacperkapusciak changed the title Add contributing docs page docs: add contributing docs page Jun 13, 2024
Copy link
Member

@piaskowyk piaskowyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏👏👏

packages/docs-reanimated/docs/guides/contributing.mdx Outdated Show resolved Hide resolved
packages/docs-reanimated/docs/guides/contributing.mdx Outdated Show resolved Hide resolved
Copy link
Collaborator

@patrycjakalinska patrycjakalinska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The link in a codeblock needs changing, eveything else is okay 🚀

packages/docs-reanimated/docs/guides/contributing.mdx Outdated Show resolved Hide resolved
packages/docs-reanimated/docs/guides/contributing.mdx Outdated Show resolved Hide resolved
Copy link
Contributor

@szydlovsky szydlovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for being a grammar nazi but I believe we could make the page much more professional with top-knotch spelling and grammar :shipit::shipit::shipit:

packages/docs-reanimated/docs/guides/contributing.mdx Outdated Show resolved Hide resolved
packages/docs-reanimated/docs/guides/contributing.mdx Outdated Show resolved Hide resolved
packages/docs-reanimated/docs/guides/contributing.mdx Outdated Show resolved Hide resolved
packages/docs-reanimated/docs/guides/contributing.mdx Outdated Show resolved Hide resolved
packages/docs-reanimated/docs/guides/contributing.mdx Outdated Show resolved Hide resolved
packages/docs-reanimated/docs/guides/contributing.mdx Outdated Show resolved Hide resolved
packages/docs-reanimated/docs/guides/contributing.mdx Outdated Show resolved Hide resolved
packages/docs-reanimated/docs/guides/contributing.mdx Outdated Show resolved Hide resolved
packages/docs-reanimated/docs/guides/contributing.mdx Outdated Show resolved Hide resolved
Copy link
Collaborator

@patrycjakalinska patrycjakalinska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Copy link
Contributor

@szydlovsky szydlovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exquisite :shipit: 👍

@maciekstosio maciekstosio added this pull request to the merge queue Jun 17, 2024
Merged via the queue into main with commit d469392 Jun 17, 2024
6 checks passed
@maciekstosio maciekstosio deleted the @maciekstosio/Contributing-docs-page branch June 17, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants