fix: don't overwrite propKeysManagedByAnimated
with nil
#6115
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Do not overwrite
propKeysManagedByAnimated
withnil
Explanation
When you copy
propKeysManagedByAnimated
- you are copyingnil
. Later on inprops gets set to
nil
and thenNSSet
withtransform
key, but in[componentView setPropKeysManagedByAnimated_DO_NOT_USE_THIS_IS_BROKEN:propKeysManagedByAnimated];
you set it back to
nil
.As a result if re-render during animation happens, it may lead to unexpected jumps during the animation.
Test plan