Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't overwrite propKeysManagedByAnimated with nil #6115

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

kirillzyusko
Copy link
Contributor

Summary

Do not overwrite propKeysManagedByAnimated with nil

Explanation

When you copy propKeysManagedByAnimated - you are copying nil. Later on in

[_mountingManager synchronouslyUpdateViewOnUIThread:tag changedProps:props componentDescriptor:*componentDescriptor];

props gets set to nil and then NSSet with transform key, but in

[componentView setPropKeysManagedByAnimated_DO_NOT_USE_THIS_IS_BROKEN:propKeysManagedByAnimated];

you set it back to nil.

As a result if re-render during animation happens, it may lead to unexpected jumps during the animation.

Test plan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant