Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SET in Expo Go #6116

Merged
merged 1 commit into from
Jun 14, 2024
Merged

Fix SET in Expo Go #6116

merged 1 commit into from
Jun 14, 2024

Conversation

piaskowyk
Copy link
Member

@piaskowyk piaskowyk commented Jun 13, 2024

Summary

This pull request aims to address the lack of Shared Element Transition in Expo Go. The issue stemmed from the initialization process of SET. In Expo Go, Reanimated gets instantiated twice (once for the Expo client and once for the actual application). During initialization, REASharedTransitionManager attempts to swizzle certain methods from react-native-screens but aims to do so only once:

static dispatch_once_t onceToken;
dispatch_once(&onceToken, ^{
  ...
  _isConfigured = YES;
});

The variable _isConfigured was only set to true if the swizzling process completed successfully. The problem appeared when the second instance attempted to set up the screens integration, as it had already been done, resulting in the new instance failing to set _isConfigured to true, even if the method swizzling was successful.

The solution involves changing _isConfigured to a class field instead of an instance field.

Test plan

Run Shared Element Transition in Expo Go

@piaskowyk
Copy link
Member Author

@EvanBacon - fixed, thanks for the help yesterday 🤝

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants