Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fallback to default behaviour when fragment not found #1566

Merged
merged 1 commit into from
Aug 22, 2022
Merged

fix: fallback to default behaviour when fragment not found #1566

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions android/src/main/java/com/swmansion/rnscreens/ScreenContainer.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,11 +161,11 @@ open class ScreenContainer<T : ScreenFragment>(context: Context?) : ViewGroup(co
// `findFragment` method throws IllegalStateException when it fails to resolve appropriate
// fragment. It might happen when e.g. React Native is loaded directly in Activity
// but some custom fragments are still used. Such use case seems highly unlikely
// so, as for now we let application crash.
// so, as for now we fallback to activity's FragmentManager in hope for the best.
try {
FragmentManager.findFragment<Fragment>(rootView).childFragmentManager
} catch (ex: IllegalStateException) {
throw IllegalStateException("Failed to find fragment for React Root View")
context.supportFragmentManager
}
}
}
Expand Down