fix: fallback to default behaviour when fragment not found #1566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkafar
force-pushed
the
@kkafar/fix-fragemnt-manager-reproduction
branch
from
2d3e0a0
to
c898679
Compare
xmflsct
added a commit
to tooot-app/app
that referenced
this pull request
Aug 19, 2022
Merged
This was referenced Oct 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1565
See first #1553 and #1562
This PR reverts changes introduced in #1562 - as for now this is a best known solution to a problem.
Changes
Silently fallback to activity's
FragmentManagerin case there is aFragmentunder activity, but it is not the one withReactRootView.Thing to note is that we are falling back silently w/o any warning.
Test code and steps to reproduce
See #1565, #1553
Checklist