Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fallback to default behaviour when fragment not found #1566

Merged
merged 1 commit into from
Aug 22, 2022

Conversation

kkafar
Copy link
Member

@kkafar kkafar commented Aug 19, 2022

Description

Fixes #1565

See first #1553 and #1562

This PR reverts changes introduced in #1562 - as for now this is a best known solution to a problem.

Changes

Silently fallback to activity's FragmentManager in case there is a Fragment under activity, but it is not the one with ReactRootView.

Thing to note is that we are falling back silently w/o any warning.

Test code and steps to reproduce

See #1565, #1553

Checklist

  • Included code example that can be used to test this change
  • Ensured that CI passes

@kkafar kkafar force-pushed the @kkafar/fix-fragemnt-manager-reproduction branch from 2d3e0a0 to c898679 Compare August 19, 2022 12:23
@kkafar kkafar linked an issue Aug 19, 2022 that may be closed by this pull request
xmflsct added a commit to tooot-app/app that referenced this pull request Aug 19, 2022
@xmflsct xmflsct mentioned this pull request Aug 19, 2022
@kkafar kkafar merged commit 9bc47fb into main Aug 22, 2022
@kkafar kkafar deleted the @kkafar/fix-fragemnt-manager-reproduction branch August 22, 2022 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crashing on Android since upgrading to 3.16.0
1 participant