fix(Android): Add backward compatibility for prefabs #2088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tboba
changed the title
tboba
reviewed
Apr 2, 2024
Comment on lines
+183
to
+187
| implementation 'androidx.appcompat:appcompat:1.4.2' | ||
| implementation 'androidx.fragment:fragment:1.3.6' | ||
| implementation 'androidx.coordinatorlayout:coordinatorlayout:1.2.0' | ||
| implementation 'androidx.swiperefreshlayout:swiperefreshlayout:1.1.0' | ||
| implementation 'com.google.android.material:material:1.9.0' | ||
| implementation 'com.google.android.material:material:1.6.1' |
There was a problem hiding this comment.
This is needed, because of the error while building a project: Can't determine type for tag '<macro name="m3_comp_assist_chip_container_shape">?attr/shapeAppearanceCornerSmall</macro>. Since we're not using any features from Material 3, it's more important to patch this (at least for now 😛).
chrisbobbe
added a commit
to chrisbobbe/zulip-mobile
that referenced
this pull request
Apr 4, 2024
This is step one toward zulip#5847. We hold back react-native-screens at 3.29.0. That's because 3.30 breaks compatibility with RN v0.68 in a certain way, and although the 3.31 release candidate addresses one source of that incompatibility -- software-mansion/react-native-screens#2088 -- there seems to be another. In particular, after the app starts up on Android, I get errors: Error: Requiring module "node_modules/react-native-screens/src/index.tsx", which threw an exception: Error: Exception in HostObject::get(propName:RNSModule): java.lang.UnsatisfiedLinkError: dalvik.system.PathClassLoader[DexPathList[[zip file "/data/app/com.zulipmobile.debug-cCKhUjMGcecB6tGNtf5jiQ==/base.apk"],nativeLibraryDirectories=[/data/app/com.zulipmobile.debug-cCKhUjMGcecB6tGNtf5jiQ==/lib/arm64, /data/app/com.zulipmobile.debug-cCKhUjMGcecB6tGNtf5jiQ==/base.apk!/lib/arm64-v8a, /system/lib64]]] couldn't find "librnscreens.so" […] and TypeError: undefined is not an object (evaluating '_$$_REQUIRE(_dependencyMap[16], "react-native-screens").screensEnabled') This error is located at: in CardStack (at StackView.tsx:462) in KeyboardManager (at StackView.tsx:458) in SafeAreaProviderCompat (at StackView.tsx:455) in RNGestureHandlerRootView (at GestureHandlerRootView.android.tsx:22) in GestureHandlerRootView (at StackView.tsx:454) in StackView (at createStackNavigator.tsx:87) in StackNavigator (at AppNavigator.js:140) in AppNavigator (at ZulipNavigationContainer.js:65) in EnsureSingleNavigator (at BaseNavigationContainer.tsx:411) in BaseNavigationContainer (at NavigationContainer.tsx:91) in ThemeProvider (at NavigationContainer.tsx:90) in NavigationContainer (at ZulipNavigationContainer.js:58) in ZulipAppContainer (at ZulipMobile.js:83) […] which I don't really understand but I suspect might require us to adopt React Native's "Fabric" system which we don't want to bother with for this legacy app.
gnprice
pushed a commit
to chrisbobbe/zulip-mobile
that referenced
this pull request
Apr 4, 2024
This is step one toward zulip#5847. We hold back react-native-screens at 3.29.0. That's because 3.30 breaks compatibility with RN v0.68 in a certain way, and although the 3.31 release candidate addresses one source of that incompatibility -- software-mansion/react-native-screens#2088 -- there seems to be another. In particular, after the app starts up on Android, I get errors: Error: Requiring module "node_modules/react-native-screens/src/index.tsx", which threw an exception: Error: Exception in HostObject::get(propName:RNSModule): java.lang.UnsatisfiedLinkError: dalvik.system.PathClassLoader[DexPathList[[zip file "/data/app/com.zulipmobile.debug-cCKhUjMGcecB6tGNtf5jiQ==/base.apk"],nativeLibraryDirectories=[/data/app/com.zulipmobile.debug-cCKhUjMGcecB6tGNtf5jiQ==/lib/arm64, /data/app/com.zulipmobile.debug-cCKhUjMGcecB6tGNtf5jiQ==/base.apk!/lib/arm64-v8a, /system/lib64]]] couldn't find "librnscreens.so" […] and TypeError: undefined is not an object (evaluating '_$$_REQUIRE(_dependencyMap[16], "react-native-screens").screensEnabled') This error is located at: in CardStack (at StackView.tsx:462) in KeyboardManager (at StackView.tsx:458) in SafeAreaProviderCompat (at StackView.tsx:455) in RNGestureHandlerRootView (at GestureHandlerRootView.android.tsx:22) in GestureHandlerRootView (at StackView.tsx:454) in StackView (at createStackNavigator.tsx:87) in StackNavigator (at AppNavigator.js:140) in AppNavigator (at ZulipNavigationContainer.js:65) in EnsureSingleNavigator (at BaseNavigationContainer.tsx:411) in BaseNavigationContainer (at NavigationContainer.tsx:91) in ThemeProvider (at NavigationContainer.tsx:90) in NavigationContainer (at ZulipNavigationContainer.js:58) in ZulipAppContainer (at ZulipMobile.js:83) […] which I don't really understand but I suspect might require us to adopt React Native's "Fabric" system which we don't want to bother with for this legacy app.
This was referenced May 22, 2024
This was referenced May 25, 2024
This was referenced Jun 3, 2024
|
Do we still need this code if we only support RN >= 71? https://github.com/software-mansion/react-native-screens#supported-react-native-version. cc @piaskowyk maybe we can revert some of the code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes backward compatibility with React Native versions older than 0.71. The issue was caused by using prefabs in the screen transition animation feature. I added a check that makes this feature available since React Native 0.71
Tested against RN versions:
Fixes #2082