Skip to content

Commit

Permalink
deps: Run yarn upgrade
Browse files Browse the repository at this point in the history
This is step one toward zulip#5847.

We hold back react-native-screens at 3.29.0. That's because 3.30
breaks compatibility with RN v0.68 in a certain way, and although
the 3.31 release candidate addresses one source of that
incompatibility --
  software-mansion/react-native-screens#2088
-- there seems to be another. In particular, after the app starts up
on Android, I get errors:

  Error: Requiring module
    "node_modules/react-native-screens/src/index.tsx", which threw an
    exception: Error: Exception in HostObject::get(propName:RNSModule):
    java.lang.UnsatisfiedLinkError:
    dalvik.system.PathClassLoader[DexPathList[[zip file "/data/app/com.zulipmobile.debug-cCKhUjMGcecB6tGNtf5jiQ==/base.apk"],nativeLibraryDirectories=[/data/app/com.zulipmobile.debug-cCKhUjMGcecB6tGNtf5jiQ==/lib/arm64, /data/app/com.zulipmobile.debug-cCKhUjMGcecB6tGNtf5jiQ==/base.apk!/lib/arm64-v8a, /system/lib64]]]
    couldn't find "librnscreens.so"

    […]

and

  TypeError: undefined is not an object (evaluating '_$$_REQUIRE(_dependencyMap[16], "react-native-screens").screensEnabled')

  This error is located at:
      in CardStack (at StackView.tsx:462)
      in KeyboardManager (at StackView.tsx:458)
      in SafeAreaProviderCompat (at StackView.tsx:455)
      in RNGestureHandlerRootView (at GestureHandlerRootView.android.tsx:22)
      in GestureHandlerRootView (at StackView.tsx:454)
      in StackView (at createStackNavigator.tsx:87)
      in StackNavigator (at AppNavigator.js:140)
      in AppNavigator (at ZulipNavigationContainer.js:65)
      in EnsureSingleNavigator (at BaseNavigationContainer.tsx:411)
      in BaseNavigationContainer (at NavigationContainer.tsx:91)
      in ThemeProvider (at NavigationContainer.tsx:90)
      in NavigationContainer (at ZulipNavigationContainer.js:58)
      in ZulipAppContainer (at ZulipMobile.js:83)

      […]

which I don't really understand but I suspect might require us to
adopt React Native's "Fabric" system which we don't want to bother
with for this legacy app.
  • Loading branch information
chrisbobbe committed Apr 4, 2024
1 parent cb4a07e commit a4d86b5
Show file tree
Hide file tree
Showing 4 changed files with 1,051 additions and 981 deletions.
20 changes: 10 additions & 10 deletions ios/Podfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -338,7 +338,7 @@ PODS:
- React
- RNCPushNotificationIOS (1.11.0):
- React-Core
- RNGestureHandler (2.15.0):
- RNGestureHandler (2.16.0):
- React-Core
- RNReanimated (2.2.4):
- DoubleConversion
Expand Down Expand Up @@ -372,14 +372,14 @@ PODS:
- RNScreens (3.29.0):
- React-Core
- React-RCTImage
- RNSentry (5.19.0):
- RNSentry (5.20.0):
- React-Core
- Sentry/HybridSDK (= 8.17.1)
- Sentry/HybridSDK (= 8.21.0)
- RNVectorIcons (9.2.0):
- React-Core
- Sentry/HybridSDK (8.17.1):
- SentryPrivate (= 8.17.1)
- SentryPrivate (8.17.1)
- Sentry/HybridSDK (8.21.0):
- SentryPrivate (= 8.21.0)
- SentryPrivate (8.21.0)
- Toast (4.0.0)
- Yoga (1.14.0)

Expand Down Expand Up @@ -640,13 +640,13 @@ SPEC CHECKSUMS:
RNCClipboard: 60fed4b71560d7bfe40e9d35dea9762b024da86d
RNCMaskedView: 0e1bc4bfa8365eba5fbbb71e07fbdc0555249489
RNCPushNotificationIOS: 64218f3c776c03d7408284a819b2abfda1834bc8
RNGestureHandler: 0cba6c7c51a90cd793cf2475cf7fdca613ede300
RNGestureHandler: 998887f1b2c6098ffa2506402087c0e8ef5d69a1
RNReanimated: e7d8afaf8fed4b3bf1a46e06adb2e04a2b248f1c
RNScreens: fa9b582d85ae5d62c91c66003b5278458fed7aaa
RNSentry: 31f4e38ea1d87d3693f634cbe377640bde583588
RNSentry: f30463ce11af9cfec0dde79265d29e10c3b902d7
RNVectorIcons: fcc2f6cb32f5735b586e66d14103a74ce6ad61f8
Sentry: d9f99f9cc13777c5d938650c1e1c85047bb4f0d1
SentryPrivate: 839b1e58addf58624087a80b2628e543193fa8ef
Sentry: ebc12276bd17613a114ab359074096b6b3725203
SentryPrivate: d651efb234cf385ec9a1cdd3eff94b5e78a0e0fe
Toast: 91b396c56ee72a5790816f40d3a94dd357abc196
Yoga: 0bc4b37c3b8a345336ff601e2cf7d9704bab7e93

Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@
"react-native-photo-view": "alwx/react-native-photo-view#91b873c85",
"react-native-reanimated": "^2.2.0 <2.3.0",
"react-native-safe-area-context": "^4.3.1",
"react-native-screens": "^3.13.1",
"react-native-screens": "^3.13.1 <3.30.0",
"react-native-simple-toast": "^1.1.4",
"react-native-tab-view": "^2.15.2",
"react-native-url-polyfill": "^1.3.0",
Expand Down
2 changes: 1 addition & 1 deletion src/webview/js/generatedEs3.js
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ var compiledWebviewJs = (function (exports) {
}
function _toPropertyKey(t) {
var i = _toPrimitive(t, "string");
return "symbol" == typeof i ? i : String(i);
return "symbol" == typeof i ? i : i + "";
}
function _defineProperty(obj, key, value) {
key = _toPropertyKey(key);
Expand Down

0 comments on commit a4d86b5

Please sign in to comment.