fix: don't use AnimatedNativeScreen when stackPresentation prop is not set #2107

WoLewicki · 2024-04-19T11:37:36Z

Description

All navigators except native-stack does not set stackPresentation so it resolved in AnimatedNativeModalScreen making all navigators that are nested or under some views not work with pressability. Follow-up to #2028

Changes

Added undefined case for setting AnimatedNativeScreen

Test code and steps to reproduce

You can check Test1214.tsx or Test2028.tsx (after changing import to @react-navigation/stack) in order to test targets of touchables.

Checklist

Ensured that CI passes

tboba

Just tested it out on both architectures, LGTM! 🎉

roryabraham · 2024-04-19T21:14:30Z

verified this fixed the problem in a release build of the Expensify app

satya164 · 2024-04-21T11:49:38Z

src/components/Screen.tsx

@@ -79,6 +79,7 @@ export class InnerScreen extends React.Component<ScreenProps> {
      // Due to how Yoga resolves layout, we need to have different components for modal nad non-modal screens
      const AnimatedScreen =
        Platform.OS === 'android' ||
+        stackPresentation === undefined ||


Wouldn't it be better to do something like stackPresentation === 'modal' ? AnimatedNativeModalScreen : AnimatedNativeScreen - use modal when necessary and regular screen for rest, instead of specifying all the cases where it won't be a modal?

This check will probably be updated when modals on Android and other types of modals on iOS by @kkafar will be merged. I'd leave it like that for now and come back to it when it's done but if you feel like it should be done here, then we can do it 🤷‍♂️

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [react-native-screens](https://togithub.com/software-mansion/react-native-screens) | [`^3.30.1` -> `^3.31.1`](https://renovatebot.com/diffs/npm/react-native-screens/3.30.1/3.31.1) | [![age](https://developer.mend.io/api/mc/badges/age/npm/react-native-screens/3.31.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/react-native-screens/3.31.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/react-native-screens/3.30.1/3.31.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/react-native-screens/3.30.1/3.31.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>software-mansion/react-native-screens (react-native-screens)</summary> ### [`v3.31.1`](https://togithub.com/software-mansion/react-native-screens/compare/3.31.0...7aa5e7b022d2aa55d05f752f7127a6d142b2b44b) [Compare Source](https://togithub.com/software-mansion/react-native-screens/compare/3.31.0...3.31.1) ### [`v3.31.0`](https://togithub.com/software-mansion/react-native-screens/releases/tag/3.31.0) [Compare Source](https://togithub.com/software-mansion/react-native-screens/compare/3.30.1...3.31.0) Minor release including adding support for React Native 0.74 and fixing targets of the touchables on the JS Stack. Thanks for following along! 💙 #### What's Changed #### 🐛 Bug fixes - Don't use AnimatedNativeScreen when stackPresentation prop is not set by [@WoLewicki](https://togithub.com/WoLewicki) in [software-mansion/react-native-screens#2107 - Change retrieving window in FullWindowOverlay by [@tboba](https://togithub.com/tboba) in [software-mansion/react-native-screens#2031 #### 🔢 Miscellaneous - Bump yarn to latest stable (4.1.1) by [@maciekstosio](https://togithub.com/maciekstosio) in [software-mansion/react-native-screens#2097 - Add RCT-Image to RNScreens.podspec by [@WoLewicki](https://togithub.com/WoLewicki) in [software-mansion/react-native-screens#2089 - Fix emit type parameters by [@mym0404](https://togithub.com/mym0404) in [software-mansion/react-native-screens#2087 #### New Contributors - [@mym0404](https://togithub.com/mym0404) made their first contribution in [software-mansion/react-native-screens#2087 - [@maciekstosio](https://togithub.com/maciekstosio) made their first contribution in [software-mansion/react-native-screens#2097 #### 🙌 Thank you for your contributions! **Full Changelog**: software-mansion/react-native-screens@3.31.0-rc.1...3.31.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 5pm,every weekend" in timezone America/Los_Angeles, Automerge - "after 5pm,every weekend" in timezone America/Los_Angeles. 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/valora-inc/wallet).  --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: valora-bot <valorabot@valoraapp.com>

fix: AnimatedNativeScreen when stackPresentation not set

ec5a5b7

This was referenced Apr 19, 2024

Header height not getting calculated in pageY value for components in new architecture facebook/react-native#43500

Open

fix: non-clickable elements on iOS Expensify/App#40560

Merged

tboba approved these changes Apr 19, 2024

View reviewed changes

roryabraham mentioned this pull request Apr 19, 2024

[HOLD] Clicks are interrupted on iOS Expensify/App#40613

Open

6 tasks

satya164 reviewed Apr 21, 2024

View reviewed changes

tboba changed the title ~~fix: AnimatedNativeScreen when stackPresentation not set~~ fix: don't use AnimatedNativeScreen when stackPresentation prop is not set Apr 23, 2024

tboba merged commit c110679 into main Apr 23, 2024
2 of 3 checks passed

tboba deleted the @wolewicki/normal-screen-in-navigators branch April 23, 2024 10:05

WoLewicki mentioned this pull request May 6, 2024

Touchable components stop responding randomly facebook/react-native#36710

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: don't use AnimatedNativeScreen when stackPresentation prop is not set #2107

fix: don't use AnimatedNativeScreen when stackPresentation prop is not set #2107

WoLewicki commented Apr 19, 2024 •

edited by tboba

tboba left a comment

roryabraham commented Apr 19, 2024

satya164 Apr 21, 2024

WoLewicki Apr 22, 2024

fix: don't use AnimatedNativeScreen when stackPresentation prop is not set #2107

fix: don't use AnimatedNativeScreen when stackPresentation prop is not set #2107

Conversation

WoLewicki commented Apr 19, 2024 • edited by tboba

Description

Changes

Test code and steps to reproduce

Checklist

tboba left a comment

Choose a reason for hiding this comment

roryabraham commented Apr 19, 2024

satya164 Apr 21, 2024

Choose a reason for hiding this comment

WoLewicki Apr 22, 2024

Choose a reason for hiding this comment

WoLewicki commented Apr 19, 2024 •

edited by tboba