Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reanimated on old architecture #1869

Merged
merged 7 commits into from
Sep 15, 2022

Conversation

WoLewicki
Copy link
Member

@WoLewicki WoLewicki commented Sep 14, 2022

PR adding option for Double for all props that were of type NumberProp on Android so reanimated works the same as before on old architecture. It also introduces the change of how fill and stroke should be constructed for options not going through render method, e.g. react-native-reanimated. An example of how to handle it can be seen in the provided example: https://github.com/react-native-svg/react-native-svg/pull/1869/files#diff-76a76277daf14518270e8aea8a5e9358a8215d7e4276d2e5f1c4fe95107cdc20

@WoLewicki WoLewicki changed the title feat: change fill prop value to payload fix: reanimated on old architecture Sep 15, 2022
@WoLewicki WoLewicki merged commit 3a04189 into main Sep 15, 2022
@WoLewicki WoLewicki deleted the @wolewicki/make-reanimated-work-on-paper branch September 15, 2022 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant