Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix setNativeProps type #2058

Merged
merged 4 commits into from May 23, 2023
Merged

Fix setNativeProps type #2058

merged 4 commits into from May 23, 2023

Conversation

fauri13
Copy link
Contributor

@fauri13 fauri13 commented May 20, 2023

Summary

Setting Object to the props type does not allow passing any object to the method. So in TypeScript when using the method for example with Path, you will get an error when passing the d:

this.pathComponent?.setNativeProps({ d })
Argument of type '{ d: string; }' is not assignable to parameter of type 'Object & { matrix?: ColumnMajorTransformMatrix | undefined; fill?: ColorValue | undefined; } & TransformProps'.
  Object literal may only specify known properties, and 'd' does not exist in type 'Object & { matrix?: ColumnMajorTransformMatrix | undefined; fill?: ColorValue | undefined; } & TransformProps'
.ts(2345)

Instead ob Object, you should use at least P so it allows the original props of the component you are using.

Test Plan

Only Type checking is modified, so it does not affect the functionality.

Compatibility

Not aplicable

Checklist

  • I have tested this on a device and a simulator
  • I added documentation in README.md
  • [x ] I updated the typed files (typescript)
  • I added a test for the API in the __tests__ folder

Setting Object to the props type does not allow passing any object to the method. So in TypeScript when using the method for example with Path, you will get an error when passing the d:
this.component?.setNativeProps({ d }) => 
Argument of type '{ d: string; }' is not assignable to parameter of type 'Object & { matrix?: ColumnMajorTransformMatrix | undefined; fill?: ColorValue | undefined; } & TransformProps'.
  Object literal may only specify known properties, and 'd' does not exist in type 'Object & { matrix?: ColumnMajorTransformMatrix | undefined; fill?: ColorValue | undefined; } & TransformProps'.ts(2345)

Instead ob Object, you should use at least P so it allows the original props of the component you are using.
@WoLewicki
Copy link
Member

@fauri13 it seems that the job is failing. Could you take a look at it locally and resolve it?

@fauri13
Copy link
Contributor Author

fauri13 commented May 23, 2023

@fauri13 it seems that the job is failing. Could you take a look at it locally and resolve it?

I've changed the other types as well, now it's compiling.

@WoLewicki WoLewicki merged commit 9883614 into software-mansion:main May 23, 2023
1 check passed
@fauri13 fauri13 deleted the patch-1 branch May 23, 2023 10:32
renovate bot added a commit to valora-inc/wallet that referenced this pull request Oct 19, 2023
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
|
[react-native-svg](https://togithub.com/react-native-community/react-native-svg)
| [`^13.9.0` ->
`^13.14.0`](https://renovatebot.com/diffs/npm/react-native-svg/13.9.0/13.14.0)
|
[![age](https://developer.mend.io/api/mc/badges/age/npm/react-native-svg/13.14.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/react-native-svg/13.14.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/react-native-svg/13.9.0/13.14.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/react-native-svg/13.9.0/13.14.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>react-native-community/react-native-svg
(react-native-svg)</summary>

###
[`v13.14.0`](https://togithub.com/software-mansion/react-native-svg/releases/tag/v13.14.0)

[Compare
Source](https://togithub.com/react-native-community/react-native-svg/compare/v13.13.0...v13.14.0)

PR adding improvements to the library. Thanks for all your contributions
🚀

#### What's Changed

- Create FUNDING.yml by [@&#8203;aleqsio](https://togithub.com/aleqsio)
in
[software-mansion/react-native-svg#2133
- docs: Update deprecated expo install instructions to \`npx expo
install´ by
[@&#8203;GabrieldosSantosOliveira](https://togithub.com/GabrieldosSantosOliveira)
in
[software-mansion/react-native-svg#2128
- \[macOS]\[Xcode 15] Avoid using dirtyRect in `drawRect:` by
[@&#8203;Saadnajmi](https://togithub.com/Saadnajmi) in
[software-mansion/react-native-svg#2136
- fix: error for transform on web by
[@&#8203;WoLewicki](https://togithub.com/WoLewicki) in
[software-mansion/react-native-svg#2139
- chore(deps): bump activesupport from 6.1.7.4 to 7.0.7.2 in
/TestsExample by [@&#8203;dependabot](https://togithub.com/dependabot)
in
[software-mansion/react-native-svg#2122
- fix: web not working with reanimated in example by
[@&#8203;WoLewicki](https://togithub.com/WoLewicki) in
[software-mansion/react-native-svg#2140

#### New Contributors

- [@&#8203;aleqsio](https://togithub.com/aleqsio) made their first
contribution in
[software-mansion/react-native-svg#2133
-
[@&#8203;GabrieldosSantosOliveira](https://togithub.com/GabrieldosSantosOliveira)
made their first contribution in
[software-mansion/react-native-svg#2128
- [@&#8203;Saadnajmi](https://togithub.com/Saadnajmi) made their first
contribution in
[software-mansion/react-native-svg#2136

**Full Changelog**:
software-mansion/react-native-svg@v13.13.0...v13.14.0

###
[`v13.13.0`](https://togithub.com/software-mansion/react-native-svg/releases/tag/v13.13.0)

[Compare
Source](https://togithub.com/react-native-community/react-native-svg/compare/v13.12.0...v13.13.0)

Minor release restoring usage of
`UIGraphicsBeginImageContextWithOptions` on `macOS` since there is no
implementation for `UIGraphicsImageRendererFormat` there yet.

#### What's Changed

- feat: add macos back to Example app by
[@&#8203;WoLewicki](https://togithub.com/WoLewicki) in
[software-mansion/react-native-svg#2119

**Full Changelog**:
software-mansion/react-native-svg@v13.12.0...v13.13.0

###
[`v13.12.0`](https://togithub.com/software-mansion/react-native-svg/releases/tag/v13.12.0)

[Compare
Source](https://togithub.com/react-native-community/react-native-svg/compare/v13.11.0...v13.12.0)

Minor release introducing the change of API used on `iOS` from
[UIGraphicsBeginImageContextWithOptions](https://developer.apple.com/documentation/uikit/1623912-uigraphicsbeginimagecontextwitho)
to
[UIGraphicsImageRenderer](https://developer.apple.com/documentation/uikit/uigraphicsimagerenderer).

#### What's Changed

- feat: remove UIGraphicsBeginImageContextWithOptions from repo by
[@&#8203;WoLewicki](https://togithub.com/WoLewicki) in
[software-mansion/react-native-svg#2117

**Full Changelog**:
software-mansion/react-native-svg@v13.11.0...v13.12.0

###
[`v13.11.0`](https://togithub.com/software-mansion/react-native-svg/releases/tag/v13.11.0)

[Compare
Source](https://togithub.com/react-native-community/react-native-svg/compare/v13.10.0...v13.11.0)

Minor release cleaning the repository 🧹 Please submit any issues that
come up with the newest version 🐛 Thanks for your contributions 🚀

#### What's Changed

- fix: make web platform types compatible with native types by
[@&#8203;nderscore](https://togithub.com/nderscore) in
[software-mansion/react-native-svg#2091
- docs: update usage.md for react-native 0.72 by
[@&#8203;Letty](https://togithub.com/Letty) in
[software-mansion/react-native-svg#2104
- docs: update README.md by [@&#8203;Mhp23](https://togithub.com/Mhp23)
in
[software-mansion/react-native-svg#2110
- fix: bump packages, eslint, tsconfig, prettier and resolve all
conflicts by [@&#8203;WoLewicki](https://togithub.com/WoLewicki) in
[software-mansion/react-native-svg#2114

#### New Contributors

- [@&#8203;nderscore](https://togithub.com/nderscore) made their first
contribution in
[software-mansion/react-native-svg#2091
- [@&#8203;Letty](https://togithub.com/Letty) made their first
contribution in
[software-mansion/react-native-svg#2104
- [@&#8203;Mhp23](https://togithub.com/Mhp23) made their first
contribution in
[software-mansion/react-native-svg#2110

**Full Changelog**:
software-mansion/react-native-svg@v13.10.0...v13.11.0

###
[`v13.10.0`](https://togithub.com/software-mansion/react-native-svg/releases/tag/v13.10.0)

[Compare
Source](https://togithub.com/react-native-community/react-native-svg/compare/v13.9.0...v13.10.0)

Minor release fixing some long-standing issues, adding new features such
as web support for `toDataURL`
([software-mansion/react-native-svg#2072)
and `fallback` prop for `SvgXml` and others
([software-mansion/react-native-svg#2071).
It also adds support for RN 0.72 on **new architecture**, at the same
time dropping the support for RN 0.71 there. Thanks for all your
contributions 🚀

#### What's Changed

- Fix compilation errors on Windows by
[@&#8203;christophpurrer](https://togithub.com/christophpurrer) in
[software-mansion/react-native-svg#2045
- Fix setNativeProps type by
[@&#8203;fauri13](https://togithub.com/fauri13) in
[software-mansion/react-native-svg#2058
- fix: remove deprecated import from react-native-web by
[@&#8203;janlat](https://togithub.com/janlat) in
[software-mansion/react-native-svg#2027
- fix: Updating iOS version
[#&#8203;2038](https://togithub.com/react-native-community/react-native-svg/issues/2038)
by [@&#8203;sgabriel](https://togithub.com/sgabriel) in
[software-mansion/react-native-svg#2041
- Fix syntax error in RNSVGImageShadowNode::initialStateData by
[@&#8203;hsjoberg](https://togithub.com/hsjoberg) in
[software-mansion/react-native-svg#2079
- Fix
[#&#8203;1345](https://togithub.com/react-native-community/react-native-svg/issues/1345):
opacity does not work with currentColor on Android by
[@&#8203;laptou](https://togithub.com/laptou) in
[software-mansion/react-native-svg#2080
- chore: bump Example to 0.72 by
[@&#8203;WoLewicki](https://togithub.com/WoLewicki) in
[software-mansion/react-native-svg#2084
- chore(deps): bump fast-xml-parser from 4.1.3 to 4.2.4 in /TestsExample
by [@&#8203;dependabot](https://togithub.com/dependabot) in
[software-mansion/react-native-svg#2063
- chore(deps): bump vm2 from 3.9.14 to 3.9.19 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[software-mansion/react-native-svg#2056
- chore(deps): bump fast-xml-parser from 4.2.4 to 4.2.5 in /TestsExample
by [@&#8203;dependabot](https://togithub.com/dependabot) in
[software-mansion/react-native-svg#2085
- Add web support for toDataURL() on svg tags by
[@&#8203;chrispader](https://togithub.com/chrispader) in
[software-mansion/react-native-svg#2072
- Prevents SvgUri crashes when uri is invalid and adds fallback prop by
[@&#8203;PiotrWszolek](https://togithub.com/PiotrWszolek) in
[software-mansion/react-native-svg#2071
- chore: run prettier and lint by
[@&#8203;WoLewicki](https://togithub.com/WoLewicki) in
[software-mansion/react-native-svg#2087
- chore: bump TestsExample to 0.72 by
[@&#8203;WoLewicki](https://togithub.com/WoLewicki) in
[software-mansion/react-native-svg#2088
- feat: strokeDasharray with Animated by
[@&#8203;WoLewicki](https://togithub.com/WoLewicki) in
[software-mansion/react-native-svg#2089

#### New Contributors

- [@&#8203;christophpurrer](https://togithub.com/christophpurrer) made
their first contribution in
[software-mansion/react-native-svg#2045
- [@&#8203;fauri13](https://togithub.com/fauri13) made their first
contribution in
[software-mansion/react-native-svg#2058
- [@&#8203;janlat](https://togithub.com/janlat) made their first
contribution in
[software-mansion/react-native-svg#2027
- [@&#8203;sgabriel](https://togithub.com/sgabriel) made their first
contribution in
[software-mansion/react-native-svg#2041
- [@&#8203;laptou](https://togithub.com/laptou) made their first
contribution in
[software-mansion/react-native-svg#2080
- [@&#8203;chrispader](https://togithub.com/chrispader) made their first
contribution in
[software-mansion/react-native-svg#2072
- [@&#8203;PiotrWszolek](https://togithub.com/PiotrWszolek) made their
first contribution in
[software-mansion/react-native-svg#2071

**Full Changelog**:
software-mansion/react-native-svg@v13.9.0...v13.10.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "after 5pm,every weekend" in timezone
America/Los_Angeles, Automerge - "after 5pm,every weekend" in timezone
America/Los_Angeles.

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/valora-inc/wallet).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xOS4yIiwidXBkYXRlZEluVmVyIjoiMzcuMTkuMiIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: valora-bot <valorabot@valoraapp.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants