Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: macOS new architecture build #2341

Merged
merged 35 commits into from
Jul 23, 2024
Merged

fix: macOS new architecture build #2341

merged 35 commits into from
Jul 23, 2024

Conversation

bohdanprog
Copy link
Member

@bohdanprog bohdanprog commented Jul 10, 2024

Summary

Closes #2192
Based on recommendations from this proposition and added some changes now we can build macOS using the new architecture.

Compatibility

OS Implemented
macOS

@bohdanprog bohdanprog marked this pull request as ready for review July 10, 2024 12:10
@bohdanprog bohdanprog self-assigned this Jul 17, 2024
Copy link
Member

@WoLewicki WoLewicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@WoLewicki WoLewicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bohdanprog bohdanprog merged commit 67620f5 into main Jul 23, 2024
5 checks passed
@bohdanprog bohdanprog deleted the feat/fix-macos-new-arch branch July 23, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to build for macOS with new arch enabled
4 participants