Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added cache-path command #566

Merged
merged 2 commits into from
Aug 16, 2023
Merged

added cache-path command #566

merged 2 commits into from
Aug 16, 2023

Conversation

ametel01
Copy link
Contributor

solves #558

@ametel01 ametel01 requested a review from mkaput as a code owner August 12, 2023 05:40
maciektr
maciektr reviewed Aug 12, 2023
View reviewed changes
Copy link
Contributor

@maciektr maciektr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind adding a test case for this?

scarb/src/bin/scarb/args.rs Outdated Show resolved Hide resolved
scarb/src/bin/scarb/commands/cache_path.rs Outdated Show resolved Hide resolved
scarb/src/ops/cachepath.rs Outdated Show resolved Hide resolved
maciektr
maciektr reviewed Aug 16, 2023
View reviewed changes
Copy link
Contributor

@maciektr maciektr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff!
Would you mind rebasing into a single commit after all changes?

scarb/src/bin/scarb/args.rs Outdated Show resolved Hide resolved
scarb/src/bin/scarb/commands/cache_path.rs Outdated Show resolved Hide resolved
@ametel01
added cache-path command
bfcf617 
fmt


implemented review requests


added cache path test


changed printing fn
maciektr
maciektr approved these changes Aug 16, 2023
View reviewed changes
Copy link
Contributor

@maciektr maciektr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 👏 👏
Looks great, thank you ❤️ !

@maciektr maciektr added this pull request to the merge queue Aug 16, 2023
Merged via the queue into software-mansion:main with commit ff9b157 Aug 16, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maciektr maciektr maciektr approved these changes

@mkaput mkaput Awaiting requested review from mkaput

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ametel01 @maciektr