Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support deploy account tx #176

Merged
merged 15 commits into from Nov 9, 2022
Merged

Support deploy account tx #176

merged 15 commits into from Nov 9, 2022

Conversation

Solpatium
Copy link
Contributor

@Solpatium Solpatium commented Nov 3, 2022

Describe your changes

  • Added deploy_account support to GatewayProvider and Account (signing txs).
  • Unfortunately cairo 10.1 changed a lot (required for deploy_account) in CLI and had to change DevnetClient.
  • Bumped devnet to version supporting cairo 10.1
  • Moved hash calculations to a separate utility class

Linked issues

Closes #131

Breaking changes

  • This issue contains breaking changes

Adds one more transaction type

@Solpatium Solpatium changed the title Add WIP of deploy account Support deploy account tx Nov 3, 2022
@codecov-commenter
Copy link

codecov-commenter commented Nov 7, 2022

Codecov Report

Base: 62.67% // Head: 65.91% // Increases project coverage by +3.24% 🎉

Coverage data is based on head (d4ff6f2) compared to base (9ca1029).
Patch coverage: 95.30% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #176      +/-   ##
==========================================
+ Coverage   62.67%   65.91%   +3.24%     
==========================================
  Files          50       52       +2     
  Lines        1243     1382     +139     
  Branches       81       83       +2     
==========================================
+ Hits          779      911     +132     
- Misses        442      447       +5     
- Partials       22       24       +2     
Impacted Files Coverage Δ
...n/kotlin/com/swmansion/starknet/account/Account.kt 100.00% <ø> (ø)
...lin/com/swmansion/starknet/data/types/Responses.kt 47.54% <60.00%> (+1.11%) ⬆️
...nsion/starknet/provider/gateway/GatewayProvider.kt 87.66% <92.85%> (+0.73%) ⬆️
...on/starknet/data/types/transactions/Transaction.kt 61.93% <94.64%> (+14.22%) ⬆️
.../com/swmansion/starknet/account/StandardAccount.kt 100.00% <100.00%> (ø)
...mansion/starknet/data/ContractAddressCalculator.kt 100.00% <100.00%> (ø)
...mansion/starknet/data/TransactionHashCalculator.kt 100.00% <100.00%> (ø)
...knet/data/types/transactions/TransactionPayload.kt 100.00% <100.00%> (ø)
...alizers/JsonRpcTransactionPolymorphicSerializer.kt 50.00% <0.00%> (-16.67%) ⬇️
...tlin/com/swmansion/starknet/crypto/NativeLoader.kt 29.03% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Solpatium Solpatium marked this pull request as ready for review November 8, 2022 10:00
Copy link
Member

@cptartur cptartur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's create an issue for supporting deploy account in the rpc provider since this PR will close #131

@Solpatium
Copy link
Contributor Author

Deploy account is part of RPC 2.1, so it will be a part of #146

@Solpatium Solpatium merged commit 16b078d into main Nov 9, 2022
@Solpatium Solpatium deleted the feat/deploy-account branch November 9, 2022 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support deploy account transaction
4 participants