Improve test coverage #480
Conversation
…software-mansion/starknet-jvm into chore/427-improve-test-coverage
… payload serializer
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #480 +/- ##
==========================================
- Coverage 71.12% 70.94% -0.18%
==========================================
Files 75 88 +13
Lines 3338 3390 +52
Branches 367 375 +8
==========================================
+ Hits 2374 2405 +31
- Misses 798 817 +19
- Partials 166 168 +2 ☔ View full report in Codecov by Sentry. |
| val tag = BlockTag.valueOf(value) | ||
| val tag = BlockTag.fromValue(value) |
There was a problem hiding this comment.
Standard valueOf() takes enum's constant, while we want to retrieve enum's constant based on the value.
| if (value.toIntOrNull() != null) { | ||
| return BlockId.Number(value.toInt()) | ||
| } | ||
|
|
There was a problem hiding this comment.
Add possibility to serialize a block number.
There was a problem hiding this comment.
I added missing query transaction versions, which enable to estimate fee.
There was a problem hiding this comment.
Standard enum's valueOf() method, takes an enum constant and returns enum constant as well. I implemented fromTag() to easily allow to get const based on given value.
Describe your changes
Linked issues
Closes #427
Breaking changes