Add support for Python 3.12 #1272

tkumor3 · 2024-02-01T09:59:59Z

Closes #

Introduced changes

This PR contains breaking changes

Bumps the dev-dependencies group with 13 updates: | Package | From | To | | --- | --- | --- | | [pytest](https://github.com/pytest-dev/pytest) | `7.4.0` | `7.4.4` | | [black](https://github.com/psf/black) | `23.7.0` | `23.12.1` | | [poethepoet](https://github.com/nat-n/poethepoet) | `0.22.0` | `0.24.4` | | [coverage](https://github.com/nedbat/coveragepy) | `7.3.0` | `7.4.0` | | [pytest-asyncio](https://github.com/pytest-dev/pytest-asyncio) | `0.21.1` | `0.23.3` | | [pylint](https://github.com/pylint-dev/pylint) | `2.17.5` | `3.0.3` | | [setuptools](https://github.com/pypa/setuptools) | `68.1.2` | `69.0.3` | | [pytest-mock](https://github.com/pytest-dev/pytest-mock) | `3.11.1` | `3.12.0` | | [pytest-xdist](https://github.com/pytest-dev/pytest-xdist) | `3.3.1` | `3.5.0` | | [pyright](https://github.com/RobertCraigie/pyright-python) | `1.1.325` | `1.1.345` | | [isort](https://github.com/pycqa/isort) | `5.12.0` | `5.13.2` | | [pytest-rerunfailures](https://github.com/pytest-dev/pytest-rerunfailures) | `12.0` | `13.0` | | [cairo-lang](https://github.com/starkware-libs/cairo-lang) | `0.12.2` | `0.13.0` | Updates `pytest` from 7.4.0 to 7.4.4 - [Release notes](https://github.com/pytest-dev/pytest/releases) - [Changelog](https://github.com/pytest-dev/pytest/blob/main/CHANGELOG.rst) - [Commits](pytest-dev/pytest@7.4.0...7.4.4) Updates `black` from 23.7.0 to 23.12.1 - [Release notes](https://github.com/psf/black/releases) - [Changelog](https://github.com/psf/black/blob/main/CHANGES.md) - [Commits](psf/black@23.7.0...23.12.1) Updates `poethepoet` from 0.22.0 to 0.24.4 - [Release notes](https://github.com/nat-n/poethepoet/releases) - [Commits](nat-n/poethepoet@v0.22.0...v0.24.4) Updates `coverage` from 7.3.0 to 7.4.0 - [Release notes](https://github.com/nedbat/coveragepy/releases) - [Changelog](https://github.com/nedbat/coveragepy/blob/master/CHANGES.rst) - [Commits](nedbat/coveragepy@7.3.0...7.4.0) Updates `pytest-asyncio` from 0.21.1 to 0.23.3 - [Release notes](https://github.com/pytest-dev/pytest-asyncio/releases) - [Commits](pytest-dev/pytest-asyncio@v0.21.1...v0.23.3) Updates `pylint` from 2.17.5 to 3.0.3 - [Release notes](https://github.com/pylint-dev/pylint/releases) - [Commits](pylint-dev/pylint@v2.17.5...v3.0.3) Updates `setuptools` from 68.1.2 to 69.0.3 - [Release notes](https://github.com/pypa/setuptools/releases) - [Changelog](https://github.com/pypa/setuptools/blob/main/NEWS.rst) - [Commits](pypa/setuptools@v68.1.2...v69.0.3) Updates `pytest-mock` from 3.11.1 to 3.12.0 - [Release notes](https://github.com/pytest-dev/pytest-mock/releases) - [Changelog](https://github.com/pytest-dev/pytest-mock/blob/main/CHANGELOG.rst) - [Commits](pytest-dev/pytest-mock@v3.11.1...v3.12.0) Updates `pytest-xdist` from 3.3.1 to 3.5.0 - [Release notes](https://github.com/pytest-dev/pytest-xdist/releases) - [Changelog](https://github.com/pytest-dev/pytest-xdist/blob/master/CHANGELOG.rst) - [Commits](pytest-dev/pytest-xdist@v3.3.1...v3.5.0) Updates `pyright` from 1.1.325 to 1.1.345 - [Release notes](https://github.com/RobertCraigie/pyright-python/releases) - [Commits](RobertCraigie/pyright-python@v1.1.325...v1.1.345) Updates `isort` from 5.12.0 to 5.13.2 - [Release notes](https://github.com/pycqa/isort/releases) - [Changelog](https://github.com/PyCQA/isort/blob/main/CHANGELOG.md) - [Commits](PyCQA/isort@5.12.0...5.13.2) Updates `pytest-rerunfailures` from 12.0 to 13.0 - [Changelog](https://github.com/pytest-dev/pytest-rerunfailures/blob/master/CHANGES.rst) - [Commits](pytest-dev/pytest-rerunfailures@12.0...13.0) Updates `cairo-lang` from 0.12.2 to 0.13.0 - [Release notes](https://github.com/starkware-libs/cairo-lang/releases) - [Commits](starkware-libs/cairo-lang@v0.12.2...v0.13.0) --- updated-dependencies: - dependency-name: pytest dependency-type: direct:development update-type: version-update:semver-patch dependency-group: dev-dependencies - dependency-name: black dependency-type: direct:development update-type: version-update:semver-minor dependency-group: dev-dependencies - dependency-name: poethepoet dependency-type: direct:development update-type: version-update:semver-minor dependency-group: dev-dependencies - dependency-name: coverage dependency-type: direct:development update-type: version-update:semver-minor dependency-group: dev-dependencies - dependency-name: pytest-asyncio dependency-type: direct:development update-type: version-update:semver-minor dependency-group: dev-dependencies - dependency-name: pylint dependency-type: direct:development update-type: version-update:semver-major dependency-group: dev-dependencies - dependency-name: setuptools dependency-type: direct:development update-type: version-update:semver-major dependency-group: dev-dependencies - dependency-name: pytest-mock dependency-type: direct:development update-type: version-update:semver-minor dependency-group: dev-dependencies - dependency-name: pytest-xdist dependency-type: direct:development update-type: version-update:semver-minor dependency-group: dev-dependencies - dependency-name: pyright dependency-type: direct:development update-type: version-update:semver-patch dependency-group: dev-dependencies - dependency-name: isort dependency-type: direct:development update-type: version-update:semver-minor dependency-group: dev-dependencies - dependency-name: pytest-rerunfailures dependency-type: direct:development update-type: version-update:semver-major dependency-group: dev-dependencies - dependency-name: cairo-lang dependency-type: direct:development update-type: version-update:semver-minor dependency-group: dev-dependencies ... Signed-off-by: dependabot[bot] <support@github.com>

…bbfd5

…f event_loop

…bbfd5

Co-authored-by: ddoktorski <45050160+ddoktorski@users.noreply.github.com>

…bbfd5

…kumor/python-3.12-support

ddoktorski

I've left one comment, but overall it looks good 💪

Please also revise the Development dependencies section in the docs to remove the requirement for Python 3.9.x

pyproject.toml

.github/workflows/checks.yml

ddoktorski · 2024-02-08T13:51:22Z

.github/workflows/checks.yml

+      - name: Install setuptools
+        run: |
+          pip install --upgrade setuptools


What is the rationale behind this?

python 3.12 doesn't install it in the default

Can we use 3.11 for the setup and then omit this action?

Yep, that was the first solution! We decided with @THenry14 to use 3.12 everywhere where possible.

I guess if we use 3.11 here we can also get rid of setuptools from pyproject.toml, is that correct?

I can check it

.github/workflows/checks.yml

docs/development.rst

pyproject.toml

.github/workflows/checks.yml

.github/workflows/manual_tests.yml

docs/development.rst

.github/workflows/package.yml

Co-authored-by: ddoktorski <45050160+ddoktorski@users.noreply.github.com>

ddoktorski

I've left one more minor comment.

Please rename the title before merging 👍

.github/workflows/checks.yml

dependabot bot and others added 20 commits January 11, 2024 09:26

Merge branch 'development' into dependabot/pip/dev-dependencies-79788…

64a2940

…bbfd5

Merge branch 'development' into dependabot/pip/dev-dependencies-79788…

fce1523

…bbfd5

revert pytest-asyncio to ^0.21.1 beacause of changes in the context o…

5907b65

…f event_loop

update hash

432ccdb

fix lint

5a2e1ab

fix linter

26808d4

Add issue id to TODO

a6d542e

fix imports

a8dc9ea

format

968df99

downgrade pyright version

9f02e73

Merge branch 'development' into dependabot/pip/dev-dependencies-79788…

04b659a

…bbfd5

Update pyproject.toml

44f34d1

Co-authored-by: ddoktorski <45050160+ddoktorski@users.noreply.github.com>

fix

6e0dbb1

Add support for python 3.12*

3ac813c

Merge branch 'development' into dependabot/pip/dev-dependencies-79788…

6e22efc

…bbfd5

Merge branch 'dependabot/pip/dev-dependencies-79788bbfd5' into tomasz…

64b4fb1

…kumor/python-3.12-support

adds to many arguments

071903d

Merge branch 'dependabot/pip/dev-dependencies-79788bbfd5' into tomasz…

f2167ce

…kumor/python-3.12-support

remove v3.8 python

c55b3b2

github-actions bot assigned tkumor3 Feb 1, 2024

fix

7a9b3ca

tkumor3 changed the base branch from development to dependabot/pip/dev-dependencies-79788bbfd5 February 1, 2024 10:22

tkumor3 added 3 commits February 1, 2024 11:49

revert version 3.8

d41b507

Merge branch 'development' into tomaszkumor/python-3.12-support

e39ca94

linter

953a4c0

tkumor3 changed the base branch from dependabot/pip/dev-dependencies-79788bbfd5 to master February 1, 2024 11:27

tkumor3 changed the base branch from master to development February 1, 2024 11:28

tkumor3 added 2 commits February 1, 2024 12:42

test

f92198c

test

a0bafb6

tkumor3 added 2 commits February 7, 2024 09:35

update pyproject

7c4232b

fix

8a5a568

ddoktorski reviewed Feb 7, 2024

View reviewed changes

pyproject.toml Outdated Show resolved Hide resolved

feedback

3037c25

tkumor3 requested a review from ddoktorski February 7, 2024 13:13

tkumor3 added 5 commits February 8, 2024 09:35

remove --without py312-dev

66753cb

update

47dba76

test

d7437a4

simplyfy install cairo-lang

3c5f64f

remove cairo-lang from deps

4d28dd6

ddoktorski requested changes Feb 8, 2024

View reviewed changes

tkumor3 added 2 commits February 8, 2024 15:33

feedback

4252ad6

remove istall cairo-lang

ffb540f

tkumor3 linked an issue Feb 8, 2024 that may be closed by this pull request

Support python 3.12 #1267

Closed

tkumor3 requested a review from ddoktorski February 8, 2024 15:01

ddoktorski reviewed Feb 9, 2024

View reviewed changes

.github/workflows/checks.yml Outdated Show resolved Hide resolved

ddoktorski reviewed Feb 9, 2024

View reviewed changes

.github/workflows/manual_tests.yml Outdated Show resolved Hide resolved

ddoktorski reviewed Feb 9, 2024

View reviewed changes

docs/development.rst Outdated Show resolved Hide resolved

ddoktorski reviewed Feb 9, 2024

View reviewed changes

.github/workflows/package.yml Outdated Show resolved Hide resolved

tkumor3 and others added 4 commits February 9, 2024 10:46

Update docs/development.rst

b175700

Co-authored-by: ddoktorski <45050160+ddoktorski@users.noreply.github.com>

Update .github/workflows/checks.yml

ccfaa88

Co-authored-by: ddoktorski <45050160+ddoktorski@users.noreply.github.com>

feedback

c17bc1b

clean up

a97d06a

tkumor3 force-pushed the tomaszkumor/python-3.12-support branch from b297fe4 to a97d06a Compare February 9, 2024 13:02

tkumor3 requested a review from ddoktorski February 9, 2024 13:04

ddoktorski approved these changes Feb 9, 2024

View reviewed changes

.github/workflows/checks.yml Outdated Show resolved Hide resolved

clean up code

2c85691

tkumor3 changed the title ~~Tomaszkumor/python 3.12 support~~ Add support for Python 3.12 Feb 9, 2024

tkumor3 merged commit c44e782 into development Feb 9, 2024
16 checks passed

tkumor3 deleted the tomaszkumor/python-3.12-support branch February 16, 2024 08:46

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for Python 3.12 #1272

Add support for Python 3.12 #1272

tkumor3 commented Feb 1, 2024

ddoktorski left a comment

ddoktorski Feb 8, 2024

tkumor3 Feb 8, 2024

ddoktorski Feb 9, 2024

tkumor3 Feb 9, 2024

ddoktorski Feb 9, 2024

tkumor3 Feb 9, 2024

tkumor3 Feb 9, 2024

ddoktorski left a comment

Add support for Python 3.12 #1272

Add support for Python 3.12 #1272

Conversation

tkumor3 commented Feb 1, 2024

Introduced changes

ddoktorski left a comment

Choose a reason for hiding this comment

ddoktorski Feb 8, 2024

Choose a reason for hiding this comment

tkumor3 Feb 8, 2024

Choose a reason for hiding this comment

ddoktorski Feb 9, 2024

Choose a reason for hiding this comment

tkumor3 Feb 9, 2024

Choose a reason for hiding this comment

ddoktorski Feb 9, 2024

Choose a reason for hiding this comment

tkumor3 Feb 9, 2024

Choose a reason for hiding this comment

tkumor3 Feb 9, 2024

Choose a reason for hiding this comment

ddoktorski left a comment

Choose a reason for hiding this comment