Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crashing Chrome often. Memory leaks? #32

Closed
jasonify opened this issue Oct 18, 2017 · 5 comments
Closed

Crashing Chrome often. Memory leaks? #32

jasonify opened this issue Oct 18, 2017 · 5 comments
Assignees
Labels

Comments

@jasonify
Copy link
Collaborator

@crablar mentioned this happens to him often when developing

Could be due to the nature of live code reloading while developing? Haven't really noticed this as an issue.

@jasonify jasonify added the bug label Oct 18, 2017
@jasonify jasonify self-assigned this Oct 18, 2017
@crablar
Copy link
Member

crablar commented Oct 19, 2017

I have a lotta chrome extensions too

@joshmorel
Copy link
Contributor

I think this might have to do with the A-Player downloading all the mp3s prior to playing. This wouldn't be a problem with a few but the main view is a decently sized array of APlayers.

If you really want the mp3 playable from the main view I think we'd want to not use the preload default of 'auto' - https://aplayer.js.org/docs/#/?id=options

sed-chrome-network

@TheHollidayInn
Copy link
Contributor

TheHollidayInn commented Oct 20, 2017

I think we should only have a single player like the mobile apps. That would be more performant and correspond with normal UX

@jasonify
Copy link
Collaborator Author

jasonify commented Oct 20, 2017

:) Agreed, and that's what this new branch is doing: https://github.com/SoftwareEngineeringDaily/sedaily-front-end/tree/global-player-WIP which is why it was odd since I think Jeff was having problems even after we removed all the player objects.

@TheHollidayInn
Copy link
Contributor

Ah! I didn't see the branch. Awesome :D

@crablar crablar closed this as completed Jul 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants