Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Publish jsoniter module for Scala Native #1795

Closed
kyri-petrou opened this issue Apr 7, 2023 · 5 comments
Closed

Feature request: Publish jsoniter module for Scala Native #1795

kyri-petrou opened this issue Apr 7, 2023 · 5 comments

Comments

@kyri-petrou
Copy link
Contributor

Hi there 👋 I'm working on building Caliban client for Scala Native. Currently, the only dependency of it that doesn't publish for Scala Native is sttp's jsoniter module. jsoniter-scala recently added support for Scala Native.

Would you be interested in publishing the jsoniter module for Scala Native? I've got a working version (aiming at v3), so I can open a PR if you're happy with support it

@adamw
Copy link
Member

adamw commented Apr 7, 2023

Sure! waiting for the PR :)

@kyri-petrou
Copy link
Contributor Author

Should my PR target the master or v3 branch?

@adamw
Copy link
Member

adamw commented Apr 7, 2023

If you'd like to publish for v3, then v3, but we'll have to forward-port to master as well

@kyri-petrou
Copy link
Contributor Author

Okay sounds good. I created a PR targeting v3 and I'll create another for master once it's been approved

@kyri-petrou
Copy link
Contributor Author

kyri-petrou commented Apr 12, 2023

By the way I realised master already has a Scala Native build for jsoniter, so we don't need to forward-port

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants