-
Notifications
You must be signed in to change notification settings - Fork 299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Scala Native build for jsoniter #1796
Conversation
The build failures are due to sbt/sbt#7202, so we're waiting to see what's up with JFrog :) |
Issue seems to be marked as resolved now. @adamw should I push an empty commit to trigger the builds or are you happy to restart it? |
Unrelated to this PR, but I noticed the following warning when building Scala 3 modules: Bad option '-target:jvm-11' was ignored With Scala 2.13 I get the following warning: -target is deprecated: Use -release instead to compile against the correct platform API. Should that flag be changed to |
Ok seems to be fixed now - thanks :) As for the build flags - yeah, some cleanup is needed to adjust them for the specific versions. If you'd have the time to work on that, would be most appreciated :) |
v3 release in progress |
Can do 👍. Do you think it's worth cleaning up both v3 and v4 or shall we just focus on v4? |
I think I'd focus on v4 :) |
Resolves #1795 . This PR adds support Scala Native support for the
jsoniter
module. One caveat of this is thatjsoniter-scala
added support for SN in 2.17.4+, and these versions are not published for Scala 2.11. Are we happy to stop publishing Scala 2.11 versions of the jsoniter (JVM) module, or should we use the old version for JVM and the latest for JS / Native?I'll create a PR to
master
to port these changes to master as well once this one has been approved