Adapt validator macros #1225
Merged
Adapt validator macros #1225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamw
reviewed
May 11, 2021
| val children = symbol.children.toList.sortBy(_.name) | ||
|
|
||
| if (!children.forall(_.flags is Flags.Module) && !(symbol.flags is Flags.Enum)) { | ||
| report.throwError("All children must be objects or enum cases.") |
There was a problem hiding this comment.
enum cases can also have parameters. So we should reject e.g.:
enum Color:
case Red(x: String)
but accept:
enum Color:
case Red
but maybe this is already covered? I think we'll need a scala3-specific test here
There was a problem hiding this comment.
added test and improved error message for this scenario
adamw
reviewed
May 11, 2021
|
|
||
| enum ColorEnum { | ||
| case Green extends ColorEnum | ||
| case Pink extends ColorEnum |
There was a problem hiding this comment.
unfortunately we can't add enum here, as this will now fail to compile with scala 2. We need to create a ValidatorTest2 (or sth like that ;) ) in the scala-3 source tree
adamw
reviewed
May 11, 2021
| @@ -107,17 +107,50 @@ class ValidatorTest extends AnyFlatSpec with Matchers { | |||
| v(0) shouldBe List(ValidationError.Custom(0, "X has to be greater than 5!")) | |||
| } | |||
|
|
|||
| it should "validate enum" in { | |||
| it should "validate coproduct enum" in { | |||
| Validator.derivedEnumeration[Color](Blue) shouldBe empty | |||
There was a problem hiding this comment.
maybe in fact we can do a better test here - examining the possibleValues of the returned Validator.Enumeration?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.