Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(services): move twitch from core to service #4874

Merged
merged 38 commits into from Nov 9, 2021
Merged

feat(services): move twitch from core to service #4874

merged 38 commits into from Nov 9, 2021

Conversation

sogehige
Copy link
Collaborator

@sogehige sogehige commented Nov 2, 2021

Migration

oauth

  • botClientId
  • broadcasterClientId
  • tokenService
  • tokenServiceCustomClientId
  • tokenServiceCustomClientSecret
  • generalChannel
  • generalOwners
  • broadcasterAccessToken
  • broadcasterRefreshToken
  • broadcasterUsername
  • broadcasterExpectedScopes
  • broadcasterCurrentScopes
  • botAccessToken
  • botRefreshToken
  • botUsername
  • botExpectedScopes
  • botCurrentScopes

twitch

  • isTitleForced

chat

  • sendWithMe
  • sendAsReply
  • ignorelist
  • globalIgnoreListExclude
  • showWithAt
  • mute
  • whisperListener
CHECKLIST

@sogehige sogehige marked this pull request as draft November 2, 2021 23:41
@codecov
Copy link

codecov bot commented Nov 2, 2021

Codecov Report

Merging #4874 (081bd79) into master (6c6213d) will decrease coverage by 0.36%.
The diff coverage is 54.30%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4874      +/-   ##
==========================================
- Coverage   59.45%   59.09%   -0.37%     
==========================================
  Files         387      391       +4     
  Lines       18228    17762     -466     
  Branches     3372     3247     -125     
==========================================
- Hits        10838    10496     -342     
+ Misses       7390     7266     -124     
Flag Coverage Δ
postgres 59.05% <54.30%> (-0.39%) ⬇️
sqlite 58.61% <54.26%> (-0.56%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/graphql/schema/keyword/KeywordGroupObject.ts 100.00% <ø> (ø)
src/graphql/schema/obsWebsocket/recording.ts 100.00% <ø> (ø)
src/graphql/schema/obsWebsocket/replayBuffer.ts 100.00% <ø> (ø)
src/graphql/schema/obsWebsocket/setCurrentScene.ts 100.00% <ø> (ø)
src/graphql/schema/obsWebsocket/setMute.ts 100.00% <ø> (ø)
src/graphql/schema/obsWebsocket/setVolume.ts 100.00% <ø> (ø)
src/graphql/schema/obsWebsocket/source.ts 100.00% <ø> (ø)
src/graphql/schema/obsWebsocket/taskLog.ts 100.00% <ø> (ø)
src/graphql/schema/obsWebsocket/type.ts 100.00% <ø> (ø)
src/graphql/schema/obsWebsocket/waitMs.ts 100.00% <ø> (ø)
... and 224 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c6213d...081bd79. Read the comment docs.

@lgtm-com

This comment has been minimized.

@lgtm-com

This comment has been minimized.

@lgtm-com

This comment has been minimized.

@lgtm-com

This comment has been minimized.

@lgtm-com

This comment has been minimized.

@lgtm-com

This comment has been minimized.

@lgtm-com

This comment has been minimized.

@lgtm-com

This comment has been minimized.

@lgtm-com

This comment has been minimized.

@lgtm-com

This comment has been minimized.

@sogehige sogehige marked this pull request as ready for review November 8, 2021 12:08
@lgtm-com

This comment has been minimized.

@lgtm-com

This comment has been minimized.

@sogehige sogehige changed the title initial service setup feat(services): move twitch from core to service Nov 8, 2021
@lgtm-com
Copy link
Contributor

lgtm-com bot commented Nov 8, 2021

This pull request fixes 1 alert when merging 34c4e9e into 6c6213d - view on LGTM.com

fixed alerts:

  • 1 for Reflected cross-site scripting

@lgtm-com
Copy link
Contributor

lgtm-com bot commented Nov 8, 2021

This pull request fixes 1 alert when merging 34f2d40 into 6c6213d - view on LGTM.com

fixed alerts:

  • 1 for Reflected cross-site scripting

@lgtm-com
Copy link
Contributor

lgtm-com bot commented Nov 8, 2021

This pull request fixes 1 alert when merging fb087e7 into 6c6213d - view on LGTM.com

fixed alerts:

  • 1 for Reflected cross-site scripting

@lgtm-com
Copy link
Contributor

lgtm-com bot commented Nov 8, 2021

This pull request fixes 1 alert when merging 6652dd5 into 6c6213d - view on LGTM.com

fixed alerts:

  • 1 for Reflected cross-site scripting

@lgtm-com
Copy link
Contributor

lgtm-com bot commented Nov 8, 2021

This pull request fixes 1 alert when merging 16763c0 into 6c6213d - view on LGTM.com

fixed alerts:

  • 1 for Reflected cross-site scripting

@lgtm-com
Copy link
Contributor

lgtm-com bot commented Nov 8, 2021

This pull request fixes 1 alert when merging ce498df into 6c6213d - view on LGTM.com

fixed alerts:

  • 1 for Reflected cross-site scripting

@lgtm-com
Copy link
Contributor

lgtm-com bot commented Nov 8, 2021

This pull request fixes 1 alert when merging e0205ad into 6c6213d - view on LGTM.com

fixed alerts:

  • 1 for Reflected cross-site scripting

@lgtm-com
Copy link
Contributor

lgtm-com bot commented Nov 8, 2021

This pull request fixes 1 alert when merging 591dd16 into 6c6213d - view on LGTM.com

fixed alerts:

  • 1 for Reflected cross-site scripting

@lgtm-com
Copy link
Contributor

lgtm-com bot commented Nov 8, 2021

This pull request fixes 1 alert when merging 0d7dfae into 6c6213d - view on LGTM.com

fixed alerts:

  • 1 for Reflected cross-site scripting

@lgtm-com
Copy link
Contributor

lgtm-com bot commented Nov 8, 2021

This pull request fixes 1 alert when merging 996e748 into 6c6213d - view on LGTM.com

fixed alerts:

  • 1 for Reflected cross-site scripting

@lgtm-com
Copy link
Contributor

lgtm-com bot commented Nov 9, 2021

This pull request fixes 1 alert when merging aebcc84 into 6c6213d - view on LGTM.com

fixed alerts:

  • 1 for Reflected cross-site scripting

@lgtm-com
Copy link
Contributor

lgtm-com bot commented Nov 9, 2021

This pull request fixes 1 alert when merging 081bd79 into 6c6213d - view on LGTM.com

fixed alerts:

  • 1 for Reflected cross-site scripting

@sogehige sogehige merged commit 36f0814 into master Nov 9, 2021
@sogehige sogehige deleted the services branch November 9, 2021 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant