Refactor Termination Criterion regarding Iterations Number #225
Comments
dinkelbachjan
added a commit
that referenced
this issue
Jul 4, 2023
This PR covers the implementation of iterative reduced-order synchronous generator models, namely the PCM and TPM models. Besides, it removes the DCIM implementations, which are covered now by PCM models with zero iterations in the DP domain. It also refactors the VBR model implementations and involves a new DP-DQ interface, which is used by all DP reduced-order synchronous generator models (PCM, TPM, VBR) and shall be reused by other DQ based components in the future. Furthermore, it adds several validation notebooks to compare the different reduced-order models against each other and to compare the results of the 4th order VBR model in the WSCC benchmark system against results from PSAT. Based on #199 Rebase of #207 Related to #75, #221 and #225
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As discussed in PR #213, the iterative solution procedure, which currently allows for the performance of corrector steps by PCM and TPM synchronous generator models, needs a refactoring with respect to the implementation of its termination criterion regarding the maximum number of allowed iterations. Instead of checking in each of the synchronous generator components individually whether the number of the component iterations has reached the specified maximum allowed number, this should be checked "globally" instead by the
MNASolver. TheMNASolvercan count the number of performed iterations and compare it with the predefined allowed maximum. We currently do not expect that component-specific maximum values are of interest. This can be implemented by using the already availablemIter. Additionally, this requires a mechanism that allows for adding theMNASolvermember variable to the data logger.The text was updated successfully, but these errors were encountered: