Fix devcontainer.json #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The change in capitalization of top-level directories broke the `devcontainer.json` file. Fix the path to `Dockerfile.dev`. Signed-off-by: Philipp Jungkamp <philipp.jungkamp@rwth-aachen.de>
|
Oops, seems like I missed that because I rebased onto your first PR only after changing all the pathnames... dpsim/.devcontainer/devcontainer.json Lines 10 to 11 in 85a17d3 Is there a specific reason for starting the container as privileged and without seccomp restrictions? What is the usecase that depends on these settings? For debugging purposes, the CLI argument --cap-add=SYS_PTRACE should be sufficient.
|
|
@stv0g is |
|
It should not be required anymore |
|
The update branch button here did not work as I expected. I will merge this into a new branch to fix this before merging into the master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change in capitalization of top-level directories broke the
devcontainer.jsonfile.Fix the path to
Dockerfile.dev.Signed-off-by: Philipp Jungkamp philipp.jungkamp@rwth-aachen.de