Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update villas version #245

Merged
merged 7 commits into from
Oct 11, 2023
Merged

Update villas version #245

merged 7 commits into from
Oct 11, 2023

Conversation

pipeacosta
Copy link
Collaborator

@pipeacosta pipeacosta commented Oct 1, 2023 •
edited by dinkelbachjan

This PR updates the VILLASnode version to 5185c25. The InterfaceWorkerVillas is updated accordingly.

Solves #233

@dinkelbachjan dinkelbachjan marked this pull request as ready for review October 10, 2023 15:42
@dinkelbachjan dinkelbachjan self-requested a review October 10, 2023 15:43
dinkelbachjan
dinkelbachjan previously approved these changes Oct 10, 2023
View reviewed changes
pipeacosta and others added 7 commits October 10, 2023 18:03
@pipeacosta @dinkelbachjan
Adapted Dockerfile for cloning the latest VILLASnode version
00c48af 
Signed-off-by: pipeacosta <pipeacosta@gmail.com>
@pipeacosta @dinkelbachjan
Modified InterfaceWorkerVillas's open method according to the latest …
2e22614 
…VILLASnode version

Signed-off-by: pipeacosta <pipeacosta@gmail.com>
@pipeacosta @dinkelbachjan
Using a specific VILLASnode commit version in the Dockerfile
67558d6 
Signed-off-by: pipeacosta <pipeacosta@gmail.com>
@pipeacosta @dinkelbachjan
Updated VILLASnode version in Dockerfile.manylinux
1e8be6c 
Signed-off-by: pipeacosta <pipeacosta@gmail.com>
@pipeacosta @dinkelbachjan
Removed libwebsockets installation from source
6da46dc 
Signed-off-by: pipeacosta <pipeacosta@gmail.com>
@pipeacosta @dinkelbachjan
Update python command to python3 in test-villas-examples actions
9e9afda 
Signed-off-by: pipeacosta <pipeacosta@gmail.com>
@dinkelbachjan
fix dockerfile spacing code smell
a8ef100 
Signed-off-by: Jan Dinkelbach <jdinkelbach@eonerc.rwth-aachen.de>
@sonarcloud
Copy link

sonarcloud bot commented Oct 10, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell E 18 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.14.1) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

stv0g
stv0g approved these changes Oct 10, 2023
View reviewed changes
Copy link
Contributor

@stv0g stv0g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :) But maybe we can squash those commits together?

@dinkelbachjan dinkelbachjan merged commit ac67f2f into master Oct 11, 2023
21 of 22 checks passed
@dinkelbachjan dinkelbachjan mentioned this pull request Oct 11, 2023
Closed
@dinkelbachjan dinkelbachjan mentioned this pull request Oct 20, 2023
Closed
@stv0g stv0g deleted the update-villas-version branch February 28, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stv0g stv0g stv0g approved these changes

@dinkelbachjan dinkelbachjan dinkelbachjan approved these changes

Assignees

@pipeacosta pipeacosta

Labels
None yet
Projects
DPsim
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pipeacosta @stv0g @dinkelbachjan