Use httpx or reuqests if available #3002
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @URenko, 祝您健康! |
|
By the way, I have found a project named "handle all HTTP(s) using Requests" at https://github.com/soimort/you-get/projects?type=classic . |
|
Rebased to v0.4.1700 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have cleaned some deprecated request methods.
And then use httpx or reuqests, which has been installed in almost all python environments, if available (they are not required, and will fallback to urllib if neither is present)。
By using httpx/reuqests, we can benefit from:
I kept them for maximum compatibility with the original processing (urllib).
And has been tested in each of the 3 environments (through
make testand some personal usages).If necessary, I can add tests for the 3 environments to GitHub action.