Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MPNN designed sequence not separated correctly with multiple targets and multiple binders #141

Open
data2code opened this issue May 13, 2023 · 2 comments

Comments

@data2code
Copy link

With a toy example, my contig string is 'A 20 E 10' with a modified pdb structure. The output sequence is:
TTCCPSIRSNFNVCRLPGTPEAICATYTGCIIIPGATCPGDYAN/RRRNNDKPVDMLYPMVAMEMTLGSEFEVME

In the above output, the two target sequences (chain A and E) are combined, followed by "/", then followed by two binder sequences (20 + 10). There is no separation "/" between the two targets and the two binders.

Some initial tracing of the code points to line 27 in af.prep._prep_binder

self._lengths = [self._target_len, self._binder_len]

self._lengths only contain two elements. This is later passed on to the mpnn code, leading to mpnn think there are only two chains in sequence output. I can certainly read the sequences from the final PDB file, just wonder if this is something that needs to be fixed.

Thanks!

@sokrypton
Copy link
Owner

sokrypton commented May 13, 2023 via email

@data2code
Copy link
Author

Yes, the results are correct. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants