Implement extra-doc-files. #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes sol#206.
sol
requested changes
Dec 11, 2017
There was a problem hiding this comment.
@quasicomputational thanks for opening this PR, your work is much appreciated.
Can you please do the following:
- Rebase on current
master - I started to move simple tests to
test/EndToEndSpec.hs. So it may make sense to do this with your tests too.
sol
approved these changes
Dec 12, 2017
sol
added a commit
that referenced
this pull request
Dec 12, 2017
|
Thanks--I was going to get around to this, but you got there ahead of me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #206.