Fix minor typos #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sol
reviewed
Feb 13, 2017
src/System/SetEnv.hs
Outdated
| @@ -57,14 +57,14 @@ eRROR_ENVVAR_NOT_FOUND = 203 | |||
| -- package instead. | |||
| -- | |||
| -- Throws `Control.Exception.IOException` if @name@ is the empty string or | |||
| -- contains an equals sign. | |||
| -- contains an equal sign. | |||
There was a problem hiding this comment.
I think "equals sign" is perfectly correct and fine.
sol
reviewed
Feb 13, 2017
| setEnv :: String -> String -> IO () | ||
| setEnv key value_ | ||
| | null value = unsetEnv key | ||
| | otherwise = setEnv_ key value | ||
| where | ||
| -- NOTE: Anything that follows NUL is ignored on both POSIX and Windows. | ||
| -- We still strip it manually so that the null check above succeds if a | ||
| -- We still strip it manually so that the null check above succeeds if a |
|
I only want the second change, see my comments. If you can adapt this, it's good for merge. |
|
Made the change. Thanks for writing out the lib. |
|
Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.