Partitioned Epoch Rewards Distribution #15
Conversation
|
We should get review from Brooks, Jon, and other Labs folks that have been actively involved in the discussion here |
yeah. I have asked jwash, brooks, behzad, jon on slack DM to join the repo and start our discussion here. |
|
@t-nelson @behzadnouri @mvines Can you help to review this proposal and let me know what you think? Thanks! |
|
yep! i'll add to the queue. everytime i've tried to review previously, you were actively updating it 😅 |
There was a problem hiding this comment.
Overall comments:
- I think the proposal should be self-contained and allow the reviewers to discuss any piece. Directing to the old proposal when it had major design issues is not helping here.
- The split between computation vs distribution is just adding more ambiguity; specially in the parts related to merkle trees. The process can be better described if it is end-to-end and one coherent piece.
- Some major issues (e.g. cluster going down) are not yet addressed or only posed as questions, whereas I believe these should be resolved in the proposal before we can move to the implementation.
- The document is pretty light in detail and incomplete in some critical parts of the design. e.g. the whole merkle tree application.
|
please ping me here when you've resolved michael and behzad's concerns. it looks like they gave you plenty to chew on 🙂 |
|
Hey @HaoranYi, can you please let us know once the proposal reflects what we chatted about earlier this week? |
|
Yes, I will. Working on it today. |
No description provided.