Skip to content
This repository has been archived by the owner on Mar 20, 2024. It is now read-only.

[Bug] cargo build in tools/move-mv-llvm-compiler directory should also build move-ir-compiler #50

Closed
ksolana opened this issue Feb 22, 2023 · 1 comment · Fixed by #115
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@ksolana
Copy link
Collaborator

ksolana commented Feb 22, 2023

Since it is not built currently, cargo test fails for the tests requiring move-ir-compiler.

@ksolana ksolana added the bug Something isn't working label Feb 22, 2023
@brson
Copy link
Collaborator

brson commented Mar 3, 2023

If somebody wants to implement this, there is a pattern they can follow in the rbpf-tests harness using Once to do a one-time build of move-native. Something similar could be done for move-ir-compiler and move-compiler, though the cargo invocation needs to be a lot different - the rbpf-tests build is using the cargo from sbf-tools and building into its own target directory, whereas a build of move-ir-compiler and move-build needs to use the active toolchain and the default target directory.

@ksolana ksolana added the good first issue Good for newcomers label Apr 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants