Refactor - Replaces sub r11, imm with add r11, -imm
#488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #488 +/- ##
==========================================
+ Coverage 89.67% 89.69% +0.01%
==========================================
Files 23 23
Lines 10105 10097 -8
==========================================
- Hits 9062 9056 -6
+ Misses 1043 1041 -2
|
Lichtso
force-pushed
the
refactor/stop_using_sub_imm_for_dynamic_stack_frames
branch
from
f4dcaac
to
e8392c6
Compare
alessandrod
approved these changes
Jul 25, 2023
18 tasks
10 tasks
nvjle
pushed a commit
to anza-xyz/llvm-project
that referenced
this pull request
Dec 12, 2023
This PR replaces sub r11, imm by add r11, -imm and is the equivalent of solana-labs/rbpf#488 for the SBF target in LLVM. This is the first task in solana-labs/solana#34250
LucasSte
added a commit
to LucasSte/llvm-project
that referenced
this pull request
Jan 31, 2024
This PR replaces sub r11, imm by add r11, -imm and is the equivalent of solana-labs/rbpf#488 for the SBF target in LLVM. This is the first task in solana-labs/solana#34250
LucasSte
added a commit
to anza-xyz/llvm-project
that referenced
this pull request
Feb 16, 2024
This PR replaces sub r11, imm by add r11, -imm and is the equivalent of solana-labs/rbpf#488 for the SBF target in LLVM. This is the first task in solana-labs/solana#34250
LucasSte
added a commit
to LucasSte/llvm-project
that referenced
this pull request
Jun 28, 2024
This PR replaces sub r11, imm by add r11, -imm and is the equivalent of solana-labs/rbpf#488 for the SBF target in LLVM. This is the first task in solana-labs/solana#34250
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That way we only need one instruction which is specific to
dynamic_stack_framesandR11.In llvm the frame lowering will need to be adjusted to emit
add r11, -imminstead ofsub r11, imm:https://github.com/solana-labs/llvm-project/blob/7b8db05b564faffb522434b73b7082662171f94a/llvm/lib/Target/SBF/SBFFrameLowering.cpp#L25