[SOL] Use ADD for subtracting stack pointer #70
Conversation
LucasSte
changed the title
|
The patch LGTM (see minor nits mentioned). Note, however, that the MacOS CI failed due to some Mac flakiness (unrelated to your patch). You will need to first rebase to get a minor patch I just committed to clean that up. |
LucasSte
force-pushed
the
stack-frame
branch
from
e751171
to
714d146
Compare
LucasSte
force-pushed
the
stack-frame
branch
from
714d146
to
ae72364
Compare
| .addReg(SBF::R11) | ||
| .addImm(NumBytes); | ||
| .addImm(IsSubtract? -NumBytes : NumBytes); |
There was a problem hiding this comment.
Reminder: please be mindful of the LLVM coding conventions[*]. You can run clang-format to help identify/automate correct coding conventions. Upstream LLVM runs this automatically for submitted patches, but we do not yet do this in our local CI.
Also, when you run clang-format on future patches, only commit the diffs that are within the lines of your patch.
[*] See the links in, e.g., https://llvm.org/docs/Contributing.html#how-to-submit-a-patch
There was a problem hiding this comment.
Should I keep a single commit in the PR?
There was a problem hiding this comment.
Yes, you should do a squash commit (with updated log message for the full commit) when done. The github UI will ask you.
nvjle
merged commit 3bddeb1
into
anza-xyz:solana-rustc/16.0-2023-06-05
This PR replaces sub r11, imm by add r11, -imm and is the equivalent of solana-labs/rbpf#488 for the SBF target in LLVM. This is the first task in solana-labs/solana#34250
This PR replaces sub r11, imm by add r11, -imm and is the equivalent of solana-labs/rbpf#488 for the SBF target in LLVM. This is the first task in solana-labs/solana#34250
This PR replaces sub r11, imm by add r11, -imm and is the equivalent of solana-labs/rbpf#488 for the SBF target in LLVM. This is the first task in solana-labs/solana#34250
This PR replaces sub r11, imm by add r11, -imm and is the equivalent of solana-labs/rbpf#488 for the SBF target in LLVM. This is the first task in solana-labs/solana#34250
This PR replaces
sub r11, immbyadd r11, -immand is the equivalent of solana-labs/rbpf#488 for the SBF target in LLVM.This is the first task in solana-labs/solana#34250