updated airdrop request values #3062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current example of requesting an airdrop of 10 sol three times results in failed transactions due to the current airdrop limit of 2 sol per request and 24 sol per account per day. This PR updates the example to work within those constraints.
|
wdyt of making docs airdrop entry more robust and linking out to that instead of replicating the information here? Adding an example that fails due to too large a request, then demonstrates how to discover the cause of the failure by looking up the memo and finally making an appropriate request would be awesome! |
|
@t-nelson see updates! Is this along the lines of what you had in mind? |
t-nelson
reviewed
Apr 5, 2022
t-nelson
pushed a commit
to solana-labs/solana
that referenced
this pull request
Apr 7, 2022
* providing clarity on airdrop amount constraints This change is in response to a review of a PR in the `solana-program-library` found here: solana-labs/solana-program-library#3062 * replaced static limits with info on how to find them * removed trailing whitespace
mergify bot
pushed a commit
to solana-labs/solana
that referenced
this pull request
Apr 7, 2022
* providing clarity on airdrop amount constraints This change is in response to a review of a PR in the `solana-program-library` found here: solana-labs/solana-program-library#3062 * replaced static limits with info on how to find them * removed trailing whitespace (cherry picked from commit 781094e)
mergify bot
added a commit
to solana-labs/solana
that referenced
this pull request
Apr 7, 2022
* providing clarity on airdrop amount constraints This change is in response to a review of a PR in the `solana-program-library` found here: solana-labs/solana-program-library#3062 * replaced static limits with info on how to find them * removed trailing whitespace (cherry picked from commit 781094e) Co-authored-by: T.J. Kyner <78994885+tjkyner@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current example of requesting an airdrop of 10 sol three times results in failed transactions due to the current airdrop limit of 2 sol per request and 24 sol per account per day. This PR updates the example to work within those constraints.