Skip to content

Commit

Permalink
removes outdated and flaky test_skip_repair from retransmit-stage (#2…
Browse files Browse the repository at this point in the history
…4121)

test_skip_repair in retransmit-stage is no longer relevant because
following: #19233
repair packets are filtered out earlier in window-service and so
retransmit stage does not know if a shred is repaired or not.
Also, following turbine peer shuffle changes:
#24080
the test has become flaky since it does not take into account how peers
are shuffled for each shred.

(cherry picked from commit 2282571)

# Conflicts:
#	core/src/retransmit_stage.rs
  • Loading branch information
behzadnouri authored and mergify-bot committed Apr 25, 2022
1 parent 4f261f1 commit fcc1002
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions core/src/retransmit_stage.rs
Original file line number Diff line number Diff line change
Expand Up @@ -528,6 +528,7 @@ impl RetransmitStage {

#[cfg(test)]
mod tests {
<<<<<<< HEAD
use {
super::*,
solana_gossip::contact_info::ContactInfo,
Expand Down Expand Up @@ -617,6 +618,9 @@ mod tests {
assert_eq!(packet_batch.packets.len(), 1);
assert!(!packet_batch.packets[0].meta.repair());
}
=======
use super::*;
>>>>>>> 228257149 (removes outdated and flaky test_skip_repair from retransmit-stage (#24121))

#[test]
fn test_already_received() {
Expand Down

0 comments on commit fcc1002

Please sign in to comment.