removes turbine legacy code and already activated features #24080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbiseda
reviewed
Apr 4, 2022
| @@ -120,20 +116,12 @@ impl ClusterNodes<BroadcastStage> { | |||
| pub(crate) fn get_broadcast_addrs( | |||
| &self, | |||
| shred: &Shred, | |||
| root_bank: &Bank, | |||
| _root_bank: &Bank, | |||
There was a problem hiding this comment.
This was intentional. The upcoming changes need to be feature gated as well, so we will need the root bank here to obtain the feature set. I didn't want to remove the plumbing here and then add it back in the next commit.
| &self, | ||
| slot_leader: Pubkey, | ||
| shred: &Shred, | ||
| root_bank: &Bank, | ||
| _root_bank: &Bank, |
jbiseda
approved these changes
Apr 5, 2022
behzadnouri
added a commit
to behzadnouri/solana
that referenced
this pull request
Apr 5, 2022
test_skip_repair in retransmit-stage is no longer relevant because following: solana-labs#19233 repair packets are filtered out earlier in window-service and so retransmit stage does not know if a shred is repaired or not. Also, following turbine peer shuffle changes: solana-labs#24080 the test has become flaky since it does not take into account how peers are shuffled for each shred.
behzadnouri
added a commit
that referenced
this pull request
Apr 5, 2022
…4121) test_skip_repair in retransmit-stage is no longer relevant because following: #19233 repair packets are filtered out earlier in window-service and so retransmit stage does not know if a shred is repaired or not. Also, following turbine peer shuffle changes: #24080 the test has become flaky since it does not take into account how peers are shuffled for each shred.
mergify bot
pushed a commit
that referenced
this pull request
Apr 5, 2022
…4121) test_skip_repair in retransmit-stage is no longer relevant because following: #19233 repair packets are filtered out earlier in window-service and so retransmit stage does not know if a shred is repaired or not. Also, following turbine peer shuffle changes: #24080 the test has become flaky since it does not take into account how peers are shuffled for each shred. (cherry picked from commit 2282571)
behzadnouri
added a commit
that referenced
this pull request
Apr 5, 2022
…4121) (#24126) test_skip_repair in retransmit-stage is no longer relevant because following: #19233 repair packets are filtered out earlier in window-service and so retransmit stage does not know if a shred is repaired or not. Also, following turbine peer shuffle changes: #24080 the test has become flaky since it does not take into account how peers are shuffled for each shred. (cherry picked from commit 2282571) Co-authored-by: behzad nouri <behzadnouri@gmail.com>
behzadnouri
pushed a commit
that referenced
this pull request
Apr 6, 2022
mergify bot
pushed a commit
that referenced
this pull request
Apr 25, 2022
…4121) test_skip_repair in retransmit-stage is no longer relevant because following: #19233 repair packets are filtered out earlier in window-service and so retransmit stage does not know if a shred is repaired or not. Also, following turbine peer shuffle changes: #24080 the test has become flaky since it does not take into account how peers are shuffled for each shred. (cherry picked from commit 2282571) # Conflicts: # core/src/retransmit_stage.rs
mergify bot
added a commit
that referenced
this pull request
Apr 25, 2022
…ckport #24121) (#24663) * removes outdated and flaky test_skip_repair from retransmit-stage (#24121) test_skip_repair in retransmit-stage is no longer relevant because following: #19233 repair packets are filtered out earlier in window-service and so retransmit stage does not know if a shred is repaired or not. Also, following turbine peer shuffle changes: #24080 the test has become flaky since it does not take into account how peers are shuffled for each shred. (cherry picked from commit 2282571) # Conflicts: # core/src/retransmit_stage.rs * removes mergify merge conflicts Co-authored-by: behzad nouri <behzadnouri@gmail.com>
mergify bot
added a commit
that referenced
this pull request
Apr 26, 2022
…24080) (#24671) * removes deterministic-shred-seed feature (cherry picked from commit 855801c) * removes turbine peers shuffle patch feature (cherry picked from commit d0b850c) # Conflicts: # core/benches/cluster_nodes.rs # core/src/cluster_nodes.rs * removes legacy compatibility turbine peers shuffle code (cherry picked from commit 2b718d0) # Conflicts: # core/src/cluster_nodes.rs # gossip/tests/cluster_info.rs * removes mergify merge conflicts * retains feature-ids in feature_set.rs Co-authored-by: behzad nouri <behzadnouri@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Features are already activated on all clusters,
so the old compatibility code is no longer needed.
Summary of Changes