Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RPC API should operate on confirmed state only #2474

Closed
mvines opened this issue Jan 17, 2019 · 3 comments
Closed

RPC API should operate on confirmed state only #2474

mvines opened this issue Jan 17, 2019 · 3 comments
Milestone
Cloud Nine v0.20.0

Comments

@mvines
Copy link
Member

mvines commented Jan 17, 2019 •
edited
Loading

Currently the RPC API reflects the instantaneous state of the node. In the case of the leader's RPC API, this would be as soon as transactions are executed but not confirmed by the network. During leader rotation this can cause the appearance of a rollback to the RPC API user should a transaction be executed by the old leader but not confirmed by the cluster before the new leader takes over.

This behaviour can be observed fairly easily by running USE_INSTALL=1 ci/localnet-sanity.sh -i 1000000, which performs script/wallet-sanity.sh repeatedly on a local cluster as it rotates through leaders.

Instead the RPC API for all nodes should probably only operate on the confirmed head of the ledger somehow.

Please revert 39b929c as a part of fixing this issue
@mvines mvines added this to the v0.12 Beacons milestone Jan 17, 2019
mvines added a commit to mvines/solana that referenced this issue Jan 18, 2019
@mvines
Temporarily ignore wallet sanity failures when leader rotation is ena…
39b929c 
…bled

This commit should be reverted once solana-labs#2474 is fixed
solana-grimes pushed a commit that referenced this issue Jan 18, 2019
@mvines @solana-grimes
Temporarily ignore wallet sanity failures when leader rotation is ena…
dac28e0 
…bled

This commit should be reverted once #2474 is fixed
@mvines mvines modified the milestones: v0.12 Beacons, v0.13 Grandview Jan 29, 2019
@CriesofCarrots CriesofCarrots mentioned this issue Mar 28, 2019
Merged
@mvines
Copy link
Member Author

mvines commented May 2, 2019

solana-labs/example-tictactoe#57 is probably due to this too

@CriesofCarrots CriesofCarrots mentioned this issue May 4, 2019
Merged
@mvines
Copy link
Member Author

mvines commented May 6, 2019

cc: #3909 and #3974

@mvines mvines mentioned this issue May 6, 2019
Closed
@mvines mvines modified the milestones: Mavericks v0.18.0, v0.19.0 Aug 8, 2019
@mvines mvines mentioned this issue Sep 24, 2019
Closed
3 tasks
@mvines
Copy link
Member Author

mvines commented Oct 14, 2019

#6346

@mvines mvines closed this as completed Oct 14, 2019
mvines added a commit to mvines/test that referenced this issue Jun 12, 2020
@mvines @solana-grimes
Temporarily ignore wallet sanity failures when leader rotation is ena…
7094c18 
…bled

This commit should be reverted once solana-labs/solana#2474 is fixed
jstarry referenced this issue in jstarry/solana Aug 8, 2024
@buffalojoec
SVM: Examples: Add PayTube Example (#2474)
6051e0b 
* SVM: examples: add paytube example

* fix comment

* fix tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Cloud Nine v0.20.0
Development

No branches or pull requests
1 participant
@mvines