Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clippy cleanup for all targets and nighly rust (also support 1.44.0) #10445

Merged
merged 8 commits into from
Jun 9, 2020
Merged

Clippy cleanup for all targets and nighly rust (also support 1.44.0) #10445

merged 8 commits into from
Jun 9, 2020

Commits on Jun 8, 2020

  1. address warnings from 'rustup run beta cargo clippy --workspace' 

    minor refactoring in:
- cli/src/cli.rs
- cli/src/offline/blockhash_query.rs
- logger/src/lib.rs
- runtime/src/accounts_db.rs

expect some performance improvement AccountsDB::clean_accounts()
    @svenski123
    svenski123 committed Jun 8, 2020
    Configuration menu
    Copy the full SHA
    c7300b5 View commit details
    Browse the repository at this point in the history

  2. address warnings from 'rustup run beta cargo clippy --workspace --tests'

    @svenski123
    svenski123 committed Jun 8, 2020
    Configuration menu
    Copy the full SHA
    65fbafb View commit details
    Browse the repository at this point in the history

  3. address warnings from 'rustup run nightly cargo clippy --workspace --… 

    …all-targets'
    @svenski123
    svenski123 committed Jun 8, 2020
    Configuration menu
    Copy the full SHA
    c1d2e4c View commit details
    Browse the repository at this point in the history

  4. rustfmt

    @svenski123
    svenski123 committed Jun 8, 2020
    Configuration menu
    Copy the full SHA
    1ba790e View commit details
    Browse the repository at this point in the history

  5. fix warning stragglers

    @svenski123
    svenski123 committed Jun 8, 2020
    Configuration menu
    Copy the full SHA
    557cc1e View commit details
    Browse the repository at this point in the history

  6. properly fix clippy warnings test_vote_subscribe() 

    replace ref-to-arc with ref parameters where arc not cloned
    @svenski123
    svenski123 committed Jun 8, 2020
    Configuration menu
    Copy the full SHA
    2a1e96d View commit details
    Browse the repository at this point in the history

  7. Remove lock around JsonRpcRequestProcessor (solana-labs#10417) 

    automerge
    @garious @svenski123
    garious authored and svenski123 committed Jun 8, 2020
    Configuration menu
    Copy the full SHA
    7449edc View commit details
    Browse the repository at this point in the history

  8. make ancestors parameter optional to avoid forcing construction of em… 

    …pty hash maps
    @svenski123
    svenski123 committed Jun 8, 2020
    Configuration menu
    Copy the full SHA
    e7cd6df View commit details
    Browse the repository at this point in the history