Use LRU cache and ahash hash of shreds to filter duplicates #13976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carllin
reviewed
Dec 6, 2020
carllin
reviewed
Dec 6, 2020
sakridge
force-pushed
the
lru-cache
branch
3 times, most recently
from
528bfac
to
658fc24
Compare
sakridge
changed the title
sakridge
force-pushed
the
lru-cache
branch
4 times, most recently
from
fe95102
to
50220c7
Compare
Codecov Report
@@ Coverage Diff @@
## master #13976 +/- ##
=========================================
- Coverage 82.1% 82.1% -0.1%
=========================================
Files 382 382
Lines 93770 93781 +11
=========================================
+ Hits 77042 77050 +8
- Misses 16728 16731 +3 |
carllin
approved these changes
Dec 7, 2020
mergify bot
pushed a commit
that referenced
this pull request
Dec 8, 2020
(cherry picked from commit f660081) # Conflicts: # Cargo.lock
sakridge
added a commit
that referenced
this pull request
Dec 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Just comparing slot/index filters duplicate shreds too aggressively.
Summary of Changes
Use LRU cache of blake3 hash of the shred data to filter duplicates.
Fixes #