Ship native programs in net/-based testnets and the solana docker image #1461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
mvines
force-pushed
the
master
branch
4 times, most recently
from
c811deb
to
0ba6939
Compare
mvines
changed the title
|
@jackcmay, any objections? |
|
Possibly, I have comments/questions posted to this pr |
|
I don't see any comments/questions on my end. Did you not hit the "Submit Review" button perhaps? |
|
SDK side: solana-labs/solana-web3.js#24 |
jackcmay
reviewed
Oct 10, 2018
| @@ -107,8 +107,6 @@ sys-info = "0.5.6" | |||
| tokio = "0.1" | |||
| tokio-codec = "0.1" | |||
| untrusted = "0.6.2" | |||
|
|
|||
| [dev-dependencies] | |||
There was a problem hiding this comment.
This was required in order to build those projects as part of the development tests. How are they built now?
| @@ -0,0 +1,28 @@ | |||
| #!/bin/bash -e | |||
| # | |||
| # Installs native programs as |cargo install| doesn't know about them | |||
There was a problem hiding this comment.
crates.io does not include all projects in the workspace?
There was a problem hiding this comment.
No! Seems like they've punted on this entirely for now. cargo install will only install programs
jackcmay
approved these changes
Oct 10, 2018
vkomenda
pushed a commit
to vkomenda/solana
that referenced
this pull request
Aug 29, 2021
HaoranYi
added a commit
to HaoranYi/solana
that referenced
this pull request
May 24, 2024
…#1461) chain parallel iterator Co-authored-by: HaoranYi <haoran.yi@solana.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.